consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,130 Commits 1 Branch 0 Tags
edb51c09c23806a8be47f01a30d8e658b9e21915
Commit Graph

50 Commits

Author SHA1 Message Date
Julian Herrero
b122302c58 Use find instead of find_by_id 
Better raise a 404 HTML NotFound exception than any other unexpected error.
 2019-06-03 17:54:19 +02:00
Javi Martín
307cf24846 Use describe on feature tests 
The `type: :feature` is automatically detected by RSpec because these
tests are inside the `spec/features` folder. Using `feature` re-adds a
`type: :feature` to these files, which will result in a conflict when we
upgrade to Rails 5.1's system tests.

Because of this change, we also need to change `background` to `before`
or else these tests will fail.
 2019-05-28 16:36:54 +02:00
Javi Martín
ca40e657fb Check page after an AJAX call removing a ballot 
We were sending a new request without checking the previous one had
finished, and if it hadn't finished, the test failed.

This test started to fail after upgrading to Rails 5, since we removed
the change done in commit eda47eff which set `config.allow_concurrency`
to `false` in the test environment.

While we could re-introduce that configuration option, which might have
side effects, an easier solution is to check an AJAX request has been
completed before sending a new request depending on the previous one
seems to be a more solid option.

Note this test failed with two possible errors: "undefined method
`heading' for nil:NilClass" and "stale element reference: element is not
attached to the page document". This change fixes the second error; it
might fix the first error as well, but since I couldn't reproduce it
locally, we'll only be sure when this test stops failing in travis
builds.
 2019-04-25 20:57:19 +02:00
decabeza
d7bde5818e Update texts on check my ballot links 2019-03-28 17:16:15 +01:00
Julian Herrero
31ac8b7f55 Change single quotes to double quotes 2019-02-15 11:40:39 +01:00
Julian Herrero
6439be44f1 change CRUD for budget groups and headings 
To make it more consistent with the rest of the Admin panel,
the CRUD for budget groups and headings has been changed
from the old "all-in-one" form to a separate form for each resource.
 2018-12-14 16:34:54 +01:00
decabeza
0bf31bde6c Updates all active to is-active classes 2018-06-06 12:02:13 +02:00
Angel Perez
92af93e8bd Fix failing tests that simulated a click against the DOM 
The now-deprecated `.trigger('click')` API simulated a click against
the DOM rather a click on the UI, which made our tests fragile and
wouldn't simulate actual user interaction
 2018-03-27 14:47:51 -04:00
Angel Perez
375c43b5f1 Replace deprecated .trigger('mouseover') API with .hover 2018-03-27 14:47:49 -04:00
Angel Perez
5c53466e86 Remove unnecessary status code related assertion 2018-03-27 14:47:49 -04:00
Angel Perez
38af45d450 Replace deprecated .trigger('click') API with .click 2018-03-27 14:47:49 -04:00
decabeza
0e9190bc43 Adds heading link on different heading message 2018-03-08 11:50:09 +01:00
Bertocq
2f27a86034 Replace deprecated capybara only_path option for ignore_query 2018-01-11 00:07:56 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
7f14544f71 Enable Capybara/CurrentPathExpectation cop & fix issues 
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule

On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
 2018-01-06 23:31:41 +01:00
decabeza
75841a71be updates texts on specs 2017-05-26 17:28:04 +02:00
Juanjo Bazán
da43e9e2e4 adds spec for edge case 2017-05-17 13:03:46 +02:00
Juanjo Bazán
3b90a40476 changes copy 
proposal -> investment
 2017-05-10 12:20:38 +02:00
Juanjo Bazán
fce60b9d9a changes heading amount info into a link in ballot view 2017-05-09 13:14:03 +02:00
Juanjo Bazán
4ae6ec75e7 adds links in ballot view to no voted groups 2017-05-09 11:27:07 +02:00
Juanjo Bazán
c14a604618 adds explicit id 2017-05-08 20:03:22 +02:00
Juanjo Bazán
39ed526b89 displays correct heading name when reviewing ballot 2017-05-08 13:22:53 +02:00
Raimond Garcia
aad725faf6 Merge pull request #1523 from consul/budgets-polish 
Budgets polish
 2017-05-06 05:08:27 +02:00
rgarcia
c0488c3b3c refactors investment filters 2017-05-06 04:57:06 +02:00
rgarcia
8e7ca16c47 makes ballot's back link point to referer 2017-05-05 20:07:24 +02:00
Juanjo Bazán
5817aa8d13 fixes link in investments index header 2017-05-04 13:17:09 +02:00
Amaia Castro
7692fb9cb0 Try to avoid poltergeist error on hover 2017-01-20 19:56:33 +01:00
rgarcia
fd28f6c2b3 adds tags to investment 2017-01-08 11:37:02 +01:00
kikito
fa50e3f215 Adds new phases to budget and fixes specs 2016-12-30 18:43:15 +01:00
kikito
46901a8117 Refactors ballots_spec by removing repeated lines 2016-12-25 20:58:57 +01:00
kikito
9081810a92 Removes parameters using automatic denormalization 2016-12-25 20:38:27 +01:00
kikito
a0d79992df refactors repetitive declarations out of ballots_spec 2016-12-25 20:29:43 +01:00
kikito
f9045cf95a refactors repetitive declarations in specs 2016-12-25 20:01:28 +01:00
kikito
b1e45bfe2d refactor spec to reutilize user variable 2016-12-25 19:29:13 +01:00
kikito
3ac7d88737 Makes spec/features/budgets/ballots_spec pass 2016-12-25 12:58:22 +01:00
kikito
56b19b257d Uses add_to_ballot in a bunch of specs 2016-12-23 18:35:25 +01:00
kikito
0578fb5479 Fixes errors when adding investments to ballots in specs 2016-12-23 15:38:21 +01:00
kikito
b5c25cb6ce Starts working on the budget/ballot_spec 2016-12-22 20:28:07 +01:00
rgarcia
fdb1d4aac9 refactors specs 2016-09-10 16:22:43 +02:00
rgarcia
16794c580c groups and headings navigation 2016-09-10 16:22:43 +02:00
rgarcia
3730b0315c runs all specs 2016-09-10 16:22:43 +02:00
rgarcia
263b729ede removes delegation specs and voting via get 2016-09-10 16:22:43 +02:00
rgarcia
65f029f34c Fixes permissions and feasibility specs 2016-09-10 16:22:42 +02:00
rgarcia
4ded0350a1 removes investments from sidebar 2016-09-10 16:22:42 +02:00
rgarcia
24740578ff displays money remaining in each group 2016-09-10 16:22:42 +02:00
rgarcia
5aeec32704 simplifies spec 2016-09-10 16:22:42 +02:00
rgarcia
94d3cbb380 adds pending spec 2016-09-10 16:22:42 +02:00
rgarcia
22373c3ddd Review my votes page 2016-09-10 16:22:41 +02:00
rgarcia
1c8f4d5ff0 can remove investment projects 2016-09-10 16:22:41 +02:00
rgarcia
9839d7afd0 can add investments to ballot 2016-09-10 16:22:40 +02:00