2 Commits

Author	SHA1	Message	Date
Javi Martín	dd7d6440ec	Add and apply Capybara/VisibilityMatcher rule ... This rule was added in rubocop-rspec 1.39.0. The `visible: false` option is equivalent to `visible: :all`, but we generally use it meaning `visible: :hidden` for positive expectations and `visible: :all` for negative expectations. The only exceptations are tests where we count the number of map icons present. I'm assuming in this case we care about the number of map icons independently on whether they are currently shown in the map, so I'm keeping the `visible: :all` behavior in this case.	2020-10-25 14:23:53 +01:00
Javi Martín	9427f01442	Use system specs instead of feature specs ... We get rid of database cleaner, and JavaScript tests are faster because between tests we now rollback transactions instead of truncating the database.	2020-04-24 15:43:54 +02:00