consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,920 Commits 1 Branch 0 Tags
d20e521ee95cd08b72b6851a23261330306b464a
Commit Graph

260 Commits

Author SHA1 Message Date
rgarcia
59805e9b73 Fix specs 2018-04-05 22:16:36 +02:00
Raimond Garcia
1692abc54a Merge pull request #2374 from wairbut-m2c/upload_documents_feature 
Upload documents feature
 2018-04-05 19:39:12 +02:00
Angel Perez
0fce8ca787 Fix incorrect assertion for nested imageable example 
The example tests if a certain selector is hidden after adding
one image but the assertion expected said selector to be visible,
which made the scenario to fail at random
 2018-03-27 14:47:51 -04:00
Angel Perez
ceb38739c7 Use absolute paths for fixtures 2018-03-27 14:47:49 -04:00
decabeza
53e36850a4 Fixes documentable rubocop offences 2018-02-28 16:21:22 +01:00
decabeza
e79f64c009 Updates specs 2018-02-28 16:21:18 +01:00
Bertocq
fbfabaeda4 Fix typo at followable shared spec 2018-02-19 11:07:59 +01:00
Bertocq
44aeb7528d Fix line lenght issues on spec files 2018-02-15 23:21:03 +01:00
BertoCQ
e1d6d4a8f8 Merge pull request #2416 from wairbut-m2c/show_error_message_when_relating_content_to_itself 
Show error message when relating content to itself
 2018-02-05 12:45:56 +01:00
Vicente Mendoza
295facccb1 Test to check that returns error when it comes to relate an investment content with itself. 2018-02-02 10:57:09 +01:00
Angel Perez
88a5e8b1d2 Spec: Admins/users can destroy only their authored documentables/imageables (#2375) 2018-01-26 09:10:58 -04:00
Bertocq
62d7d08a10 Remove no longer valid scenarios: image&doc removal by admin 2018-01-24 21:50:13 +01:00
Vicente Mendoza
c3327a5da0 rebase and fix test to attach max number of files 2018-01-24 16:55:39 +01:00
Vicente Mendoza
410caced3e test added for changes at documentable's view 2018-01-24 12:48:06 +01:00
María Checa
b2054ac531 Improved relationable tests for budget investments 2018-01-12 18:26:37 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
ed16a78f42 Enables RSpec/ExampleWording and fixes all issues 
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
 2018-01-07 01:03:45 +01:00
Bertocq
d3719f0b42 Merge branch 'fix/documentable_multiple_docs' 2018-01-03 18:03:20 +01:00
Bertocq
3bf8948b11 Fix typo, dowload to download 2018-01-03 17:38:44 +01:00
Bertocq
1246bd4e62 Fix poltergeist input focus issues 2018-01-03 17:38:44 +01:00
Bertocq
e71340bccb Bring back max doc attachment scenario, using all pdf fixtures 2018-01-03 17:38:44 +01:00
Bertocq
5bf16eb1ac Remove index param from attach new file helper test function 2018-01-03 17:38:44 +01:00
BertoCQ
4885acb7ac Merge pull request #2225 from consul/chore/refactor_documents_document_partials 
Refactor documents and document view partials
 2018-01-03 17:38:16 +01:00
Bertocq
2f7e81e5ca Remove unused documentable_factory_name argument from documentable_attach_new_file helper method 2018-01-02 13:59:58 +01:00
Bertocq
d7d1a85fbb Refactor documents and document view partials 2018-01-02 13:32:42 +01:00
rgarcia
96066aee44 Validates map presence only on create 
As we are using an attr_accessor to make sure a user accepts that the
proposal “has no map”, the validation was being run in every save.

Making other things break, for example the updating of the counter
cache `cached_votes_up`, when someone voted for the proposal, as the
attr_accessor `skip_map` was not present
 2017-12-26 12:39:29 +01:00
Bertocq
f6d23df862 Avoid using eval when send can do the job 2017-12-25 23:47:55 +01:00
Bertocq
2283237d44 Avoid Looking up factories by class is deprecated and will be removed in FactoryGirl 5.0 2017-12-25 23:46:51 +01:00
Bertocq
93e6a7e6aa Fix indentation & spaces on map validation files 2017-12-25 23:34:18 +01:00
BertoCQ
d534b02b3c Merge pull request #2206 from consul/related-contents-score 
Related contents score
 2017-12-20 15:13:12 +01:00
María Checa
1e23281c28 Fixed related content tests 2017-12-20 13:43:56 +01:00
rgarcia
7889efd6ee Fix map location update 
When editing the map of a proposal or investment(the mappable) the
updated_at attribute of the mappable was not been updated and so the
map still displayed the old location after updating it
 2017-12-20 12:43:49 +01:00
Bertocq
f190d9c626 Fix related content score classname on specs 2017-12-20 03:06:53 +01:00
Bertocq
f21f5ec05e Refactor Related Content Controller score methods 2017-12-20 02:36:13 +01:00
María Checa
8e4a39a066 Updated schema and fixed tests 2017-12-19 20:45:23 +01:00
rgarcia
0152b6301c adds specs 2017-12-19 20:36:10 +01:00
María Checa
b99a2eac6f Fixed tests 2017-12-19 19:10:43 +01:00
María Checa
03aaa82d86 Improved tests 2017-12-19 17:01:35 +01:00
María Checa
4192860a73 Added and improved related content tests 2017-12-18 23:56:44 +01:00
Bertocq
70f2ee0cf5 Fix Time.now usage to Time.current to include zone 2017-12-16 17:59:16 +01:00
Raimond Garcia
9ba8ca7de3 Merge pull request #2187 from consul/notifications 
Fix notifications' exceptions
 2017-12-14 22:11:27 +01:00
rgarcia
2b52d26d82 refactors notifications into concerns and shared examples 2017-12-14 16:15:30 +01:00
Bertocq
f376707b2d Fix style of method with parameters call using parenthesis 2017-12-13 14:11:52 +01:00
Bertocq
1c863d7d84 Use activerecord model name on followable specs 2017-12-13 14:11:22 +01:00
decabeza
1d6877b797 adds setting allow_images to specs 2017-12-06 20:59:34 +01:00
Bertocq
ce0a7f6fad Rubocop autocorrections 2017-10-17 22:00:00 +02:00
rgarcia
23682fadd8 fixes document specs 2017-10-06 17:50:41 +02:00
decabeza
dd69401477 Merge branch 'master' into question-answer-documents 2017-10-06 15:18:42 +02:00