BertoCQ
4829b97cb6
Merge pull request #2431 from consul/fix_milestones_order
...
Fix milestones order
2018-02-05 15:35:00 +01:00
BertoCQ
e1d6d4a8f8
Merge pull request #2416 from wairbut-m2c/show_error_message_when_relating_content_to_itself
...
Show error message when relating content to itself
2018-02-05 12:45:56 +01:00
Bertocq
e0871e5dc6
Only update slug if empty or model condition is met
2018-02-04 23:04:48 +01:00
Bertocq
198ff0cd1f
Use updatable slug factory trait to sluggable concern
...
Slugs should only be updated on certain conditions, we need a trait that
meets that conditions and the name of the trait passed as a mandatory &
named argument on the sluggable concern
2018-02-04 23:04:48 +01:00
Bertocq
8e6e360fc8
Create traits for budget group & heading with drafting budget
2018-02-04 23:04:48 +01:00
Bertocq
8f72972344
Change budget factory name to avoid collisions
2018-02-04 23:04:47 +01:00
Bertocq
2eab6a476e
Refactor sluggable concern spec
2018-02-04 22:36:23 +01:00
Bertocq
ea089c1b87
Add missing legislation proposal commentable path
2018-02-03 23:54:22 +01:00
Bertocq
d5c7565b31
Update unreleased section of changelog
2018-02-03 23:22:59 +01:00
Bertocq
770086779e
Use new milestone order_by_publication_date order scope
2018-02-03 19:15:59 +01:00
Bertocq
a297faec4b
Add order scope to milestone for publication date
2018-02-03 19:15:31 +01:00
Bertocq
67663804c5
Improve investments milestone scenario for ordering
...
Milestones should be listed ordered by publication date instead of
creation date. The spec was creating only one milestone and not even
expecting the descriptions to be present in the page.
2018-02-03 18:46:43 +01:00
Bertocq
b39c1b5992
Recommend trying mobile viewport & screenshot on PR template
2018-02-03 18:30:14 +01:00
Bertocq
86b27b5bac
Add github issue template for flaky specs
2018-02-03 14:47:54 +01:00
Bertocq
6e9191dc7c
Budget Investment controller has no update method
2018-02-03 01:19:25 +01:00
Bertocq
04de1e19f5
Make mappable 100 line length compliant
2018-02-02 21:51:49 +01:00
Bertocq
24b1e64113
Validate MapLocation lat/long/zoom have numeric values
2018-02-02 21:37:50 +01:00
Bertocq
6f87f4b07c
Correctly check map location attr presence validations
2018-02-02 21:37:05 +01:00
BertoCQ
59b600dd1a
Merge pull request #2390 from wairbut-m2c/aperez-user-permissions-specs
...
Add specs to check users permissions to delete images & documents
2018-02-02 19:42:27 +01:00
BertoCQ
38b66e8c6c
Merge pull request #2295 from wairbut-m2c/aperez-mappable-objects
...
Improvements for Mappable objects
2018-02-02 19:26:47 +01:00
Vicente Mendoza
295facccb1
Test to check that returns error when it comes to relate an investment content with itself.
2018-02-02 10:57:09 +01:00
Vicente Mendoza
74124fb784
Control when the investment is trying to relate to itself.
2018-02-02 10:52:28 +01:00
Bertocq
2a678dfd4a
Order group headings by name on listing
2018-01-31 23:20:57 +01:00
Bertocq
c82d42fe10
Remove unnecesary spacing on spec
2018-01-31 23:19:41 +01:00
Bertocq
10d780ea4b
Add valuation flag to comment form cache key
2018-01-31 22:26:03 +01:00
Raimond Garcia
48f084d0a2
Merge pull request #2413 from consul/depfu/update/nokogiri-1.8.2
...
🚨 [security] Update nokogiri: 1.8.1 → 1.8.2 (patch)
2018-01-31 19:21:48 +01:00
depfu[bot]
11a235da4d
Update nokogiri to version 1.8.2
2018-01-31 17:44:44 +00:00
Bertocq
bca150bcd5
Prevent non-authors from viewing valuation comments
2018-01-31 18:38:44 +01:00
Bertocq
fcf5e6223b
Ensure graphql doesnt return valuation comments
2018-01-31 18:31:22 +01:00
Bertocq
c0dcd03bab
Prevent valuation comments from appearing in public pages
2018-01-31 18:14:11 +01:00
Bertocq
5420cd36bf
Disallow comment actions on valuation comments
2018-01-31 17:46:36 +01:00
Bertocq
0f4d0b4fe9
Improve valuation flag at comment form
2018-01-31 17:19:26 +01:00
Bertocq
d3d5b233c2
Increase admin investment feature spec for valuation comments feature
2018-01-31 17:08:08 +01:00
Bertocq
9cb4b03276
Disallow valuation comment creation on finished budget
2018-01-31 17:07:56 +01:00
Bertocq
b926740a32
Show valuation comments at admin investment show page
2018-01-31 16:35:45 +01:00
Bertocq
528c9be925
Refactor valuation comments into its own partial
...
It's going to be used at valuation and admin panels
2018-01-31 16:34:11 +01:00
Bertocq
a15e372f7e
Rename written_by_authors partial to dossier
...
Its more descriptive in the contexts where its rendered
2018-01-31 16:30:39 +01:00
Bertocq
e38e74169e
Improve valuation comments spec to avoid public leaks
...
Check that on both comment creation and comment reply the public facing
investment page doesn't show them
2018-01-31 16:27:07 +01:00
Raimond Garcia
b0eaece981
Merge pull request #2411 from wairbut-m2c/aperez-investments-search-by-id
...
Admins can search investments by title or ID
2018-01-31 15:44:19 +01:00
Angel Perez
47c9b343ee
Admins can search investments by title or ID ( #2401 )
2018-01-31 09:52:55 -04:00
Raimond Garcia
45d07fa16f
Merge pull request #2407 from wairbut-m2c/aperez-investment-filters-aggregation
...
Investments can be applied several filters at once
2018-01-31 14:39:02 +01:00
BertoCQ
06cd81fdbd
Merge pull request #2404 from consul/remove_investments_internal_comments
...
Remove usage of Investment's internal_comments
2018-01-31 13:47:38 +01:00
BertoCQ
05a6406189
Merge branch 'master' into remove_investments_internal_comments
2018-01-31 13:47:15 +01:00
BertoCQ
ec81f399bf
Merge pull request #2403 from consul/valuation_comments
...
Valuation comments
2018-01-31 13:46:22 +01:00
Angel Perez
137aa7e779
Add spec to test aggregation when filtering investments
2018-01-31 07:21:51 -04:00
Angel Perez
1f50e284a9
'Current applied filters' message handles multiple filters in use
2018-01-31 07:21:51 -04:00
Angel Perez
a5159672d4
Investments are now aggregated when using more than 1 advanced filter
2018-01-31 07:21:51 -04:00
Alberto García
0d64f51b78
Merge pull request #2405 from consul/more-info-pages
...
Improve texts of help page
2018-01-31 11:09:12 +01:00
BertoCQ
4020720b32
Merge pull request #2370 from consul/improve_budget_heading_style
...
Improve budget heading style
2018-01-31 02:35:51 +01:00
BertoCQ
f0f41b0403
Merge pull request #2373 from consul/single_heading_group_names
...
Improve heading names at select boxes
2018-01-31 02:35:11 +01:00