consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,771 Commits 1 Branch 0 Tags
cb15a2e25b3db45815f23589797812884785b35c
Commit Graph

8771 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertocq
830bb37189 Enable RSpec/VerifiedDoubles cop, fix issues & stash one 
Can't figureout solution for offense at spec/models/verification/management/email_spec.rb
 so its stashed at .rubocop_todo.yml

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubles
 2018-01-07 18:47:19 +01:00
Bertocq
95e86eafbb Enable RSpec/SubjectStub cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
425404b890 Enable RSpec/SingleArgumentMessageChain cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
dc1deee15a Enable RSpec/SharedContext cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
3762fd347e Enable RSpec/ScatteredSetup & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup
 2018-01-07 18:46:58 +01:00
Bertocq
f8fb32db76 Enable RSpec/ScatteredLet cop & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet
 2018-01-07 18:46:58 +01:00
Bertocq
33365479c9 Enable RSpec/ReturnFromStub cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
16eae689f9 Enable RSpec/RepeatedExample cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
 2018-01-07 18:46:32 +01:00
depfu[bot]
eed0582fae Upgrade uglifier to version 4.1.2 2018-01-07 18:12:19 +01:00
Bertocq
4f6597b200 Enable RSpec/RepeatedDescription cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription
 2018-01-07 17:45:34 +01:00
Bertocq
e89d081a47 Enable RSpec/PredicateMatcher cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher
 2018-01-07 17:42:59 +01:00
Bertocq
c6cac965dd Enable RSpec/OverwritingSetup cop without issues 2018-01-07 17:40:59 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
79a3b97c64 Enable RSpec/NestedGroups cop with a reasonable max value of 4 2018-01-07 17:38:55 +01:00
Bertocq
4c48027228 Explicitly disable RSpec/NamedSubject cop until debate is held 2018-01-07 17:36:46 +01:00
Bertocq
317247103e Enable RSpec/MultipleSubjects without issues 2018-01-07 17:07:34 +01:00
Bertocq
ce395217f8 Disable RSpec/MultipleExpectations cop with 1339 possible offenses, need to stablish a max amount after a debate 2018-01-07 17:06:43 +01:00
Bertocq
18d14dfe17 Enable RSpec/MultipleDescribes cop without issues 2018-01-07 17:04:38 +01:00
Bertocq
eb822c4a5e Enable RSpec/MessageSpies cop without issues 
EnforcedStyle: receive configuration was added to follow codebase conventions

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageSpies
 2018-01-07 16:51:11 +01:00
Bertocq
c4aa2d7093 Enable RSpec/MessageExpectation cop & fix issues 
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
 2018-01-07 16:36:18 +01:00
Bertocq
987b31d618 Enable RSpec/MessageChain cop without issues 2018-01-07 16:28:37 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
8be2df09b8 Update unreleased section of changelog 2018-01-07 15:38:45 +01:00
Bertocq
3509bfe3e4 Remove spending proposals from sitemap and its test, deprecated model 2018-01-07 15:38:44 +01:00
Bertocq
cdbf0a77e1 Improve consul.json request spec, to avoid maintaining the setting features list up with seeds.rb content 2018-01-07 15:24:46 +01:00
Bertocq
ea34aa4c4b Thank depfu free service for multiple gem ver updates on changelog 2018-01-07 13:26:26 +01:00
Bertocq
7249eb27e3 Update changelog release list 2018-01-07 13:20:12 +01:00
BertoCQ
6e4fcfb469 Merge pull request #2271 from consul/depfu/update/bullet-5.7.1 
Update bullet: 5.7.0 → 5.7.1 (patch)
 2018-01-07 12:58:38 +01:00
Bertocq
0ecfbfe55c Fix capistrano version lock on deploy.rb script to same on Gemfile 2018-01-07 12:51:42 +01:00
BertoCQ
c0708592c9 Merge pull request #2266 from consul/depfu/upgrade/cancancan-2.1.2 
Upgrade cancancan: 1.16.0 → 2.1.2 (major)
 2018-01-07 12:34:49 +01:00
BertoCQ
6f9323e5c8 Merge pull request #2265 from consul/depfu/upgrade/acts-as-taggable-on-5.0.0 
Upgrade acts-as-taggable-on: 4.0.0 → 5.0.0 (major)
 2018-01-07 12:18:29 +01:00
depfu[bot]
2847bca32d Update bullet to version 5.7.1 2018-01-07 11:05:23 +00:00
depfu[bot]
f87f8b6857 Upgrade cancancan to version 2.1.2 2018-01-07 11:53:16 +01:00
Bertocq
e3aa1131a1 Update changelog unreleased section with rubocop changes 2018-01-07 11:30:39 +01:00
BertoCQ
abfa203f5c Merge pull request #2249 from wairbut-m2c/aperez-sitemap-specs 
Specs for valid sitemap generation
 2018-01-07 11:24:43 +01:00
BertoCQ
5b0315c1e2 Merge pull request #2263 from consul/depfu/upgrade/ancestry-3.0.1 
Upgrade ancestry: 2.2.2 → 3.0.1 (major)
 2018-01-07 11:09:21 +01:00
BertoCQ
6e7631d229 Merge pull request #2267 from consul/depfu/upgrade/sitemap_generator-6.0.0 
Upgrade sitemap_generator: 5.3.1 → 6.0.0 (major)
 2018-01-07 11:07:24 +01:00
depfu[bot]
1754bfa9af Upgrade sitemap_generator to version 6.0.0 2018-01-07 10:05:51 +00:00
BertoCQ
d6b47234ec Merge pull request #2269 from consul/depfu/upgrade/social-share-button-1.1.0 
Upgrade social-share-button: 0.10.0 → 1.1.0 (major)
 2018-01-07 11:04:07 +01:00
depfu[bot]
ca266dda91 Upgrade social-share-button to version 1.1.0 2018-01-07 02:05:24 +00:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
 2018-01-07 02:28:06 +01:00
Bertocq
4bb75c3a11 Enable RSpec/LeadingSubject cop without issues 2018-01-07 02:26:40 +01:00
Bertocq
eaf66e3ec1 Enable RSpec/IteratedExpectation cop and fix issues 
Suggested refactor is only available for `.to` and not for `.not_to` :(

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
 2018-01-07 02:24:24 +01:00
Bertocq
77e6e33d35 Enable RSpec/ItBehavesLike cop without issues 2018-01-07 02:20:34 +01:00
Bertocq
54cd57de9b Enable RSpec/InvalidPredicateMatcher without issues 2018-01-07 02:19:23 +01:00
Bertocq
473e3d6466 Disable RSpec/InstanceVariable as we have 868 offenses for it 2018-01-07 02:15:43 +01:00
Bertocq
bf75b50b2f Enable RSpec/InstanceSpy cop without issues 2018-01-07 02:14:04 +01:00
Bertocq
ae04a76221 Enable RSpec/ImplicitExpect cop with convention 
Used `EnforcedStyle: should` config as there is no `is_expected.to` usage on the codebase.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitExpect
 2018-01-07 02:11:51 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
39b01b6342 Enable RSpec/Focus cop without issues 2018-01-07 02:07:02 +01:00