Commit Graph

6 Commits

Author SHA1 Message Date
Javi Martín
6d6a57636f Exclude irrelevant Consul Democracy tests in knapsack
In a fork of Consul Democracy, people can use the `:consul` task on a
test that is relevant in the original Consul Democracy but doesn't apply
to them due to their custom changes. So we're excluding tests with this
tag when running the test suite.

Knapsack 7, which we adopted in commit 070cb3185, changed the way to
exclude these tags in RSpec when using Queue Mode [1]. It now ignores
the `filter_run_excluding` option, so we have to pass the argument
directly to the knapsack task.

We're still keeping the `filter_run_excluding` option so it's used when
running the tests on a development machine. The downside, of course, is
that now we have duplicate code.

[1] https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#700
2024-09-19 13:38:31 +02:00
Javi Martín
54cefb918e Update bash script to run Knapsack Pro
We made a few experiments with forked repositeries after applying commit
dc1e0209a and everything seems to work fine, but it looks like that
isn't the case. For instance, on pull requests opened by external
contributors, the tests aren't running.

The fix we're applying is mentioned on the Knapsack Pro repository [1]
(pull request 197).

[1] https://github.com/KnapsackPro/knapsack_pro-ruby
2023-09-29 16:10:25 +02:00
Javi Martín
416b474122 Avoid timeouts in knapsack PRO
The way it's recommended since knapsack_pro version 2.3.0 [1].

[1] https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#230
2021-03-20 19:20:46 +01:00
Julian Herrero
69838c78b9 Revert "Stop using Knapsack Pro"
This reverts PR https://github.com/consul/consul/pull/3812
2019-11-06 18:58:05 +07:00
Julian Herrero
5b3d40ce8e Stop using Knapsack Pro 2019-11-04 16:58:06 +07:00
ArturT
27f46c9239 Allow forked version of repo to run tests with knapsack_pro gem without
needed API key KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC.

Based on:
https://github.com/KnapsackPro/knapsack_pro-ruby#how-to-make-knapsack_pr
o-works-for-forked-repositories-of-my-project
2017-12-05 20:10:40 +01:00