Commit Graph

12 Commits

Author SHA1 Message Date
Javi Martín
bd85aede99 Use describe on new feature tests
The `type: :feature` is automatically detected by RSpec because these
tests are inside the `spec/features` folder. Using `feature` re-adds a
`type: :feature` to these files, which will result in a conflict when we
upgrade to Rails 5.1's system tests.

Because of this change, we also need to change `background` to `before`
or else these tests will fail.

We're also adding a rubocop rule so we dont' accidentally add these
keywords again.
2019-08-07 13:53:27 +02:00
Javi Martín
765d405df1 Use Rails 5 conventions in migrations and models
We forgot to add these changes to pull requests which were in
development before we upgraded to Rails 5.

We're also moving the rubocop rules to the basic files, so we're
notified when we inherit from `ActiveRecord::Base`.
2019-08-07 13:53:27 +02:00
Julian Herrero
7066dd50d5 Allow lines to be 110 characters long 2019-05-23 13:16:02 +02:00
Javi Martín
002599231f Enable rubocop rules in config and seed files
We were unintentionally ignoring them while trying to ignore just the
schema file, migration files, and initializers generated with `rails
generate`
2019-03-20 14:34:04 +01:00
Julian Herrero
6d281affa5 Use double quotes 2019-03-15 10:29:07 +01:00
Javi Martín
e11b9ddccd Enable literal as condition rule in rubocop
This way deverlopers who don't run the ruby syntax check locally with
warnings enabled will be informed by HoundCI.
2019-02-15 20:21:35 +01:00
Javi Martín
a69004ab95 Enable useless assignment rubocop rule
This way deverlopers who don't run the ruby syntax check locally with
warnings enabled will be informed by HoundCI.
2019-02-15 16:31:34 +01:00
Julian Herrero
4af0de2d1d Enable double quotes rubocop rule 2019-01-14 13:13:37 +01:00
decabeza
15dbfdf6e8 Enable line length rubocop rule 2019-01-09 13:45:42 +01:00
Javi Martín
d3671491e8 Enable indentation width cop
This cop is necessary so the `Layout/IndentationConsistency` cop works
properly when its `EnforcedStyle` is set to `Rails`, and so incorrect
indentation for `private` methods is properly detected.
2018-12-28 14:00:41 +01:00
voodoorai2000
c1455cb93c Add not_to Rubocop rule to Hound
https://www.rubydoc.info/gems/rubocop-rspec/1.5.0/RuboCop/Cop/RSpec/NotToNot
2018-12-15 12:41:07 +01:00
Javi Martín
4048d17203 Add basic rubocop configuraton for Hound
This way we can ask contributors to follow some basic guidelines like
removing trailing whitespaces while not overwhelming them with all our
rules.
2018-10-26 11:46:17 +02:00