Javi Martín
db97f9d08c
Add and apply rubocop rules for empty lines
...
We were very inconsistent regarding these rules.
Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.
The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.
[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
rgarcia
dacc2d529d
Fix destroy document specs
...
We were linking to the document url itself, which does not have a route
associated and so the specs fails
With this commit we are using the correct path to the destroy action of
the DocumentsController.
We are also using the referrer instead of a params[:from] attribute, as
it avoids having to pass an extra parameter, making the code prettier
and it works the same way
2019-01-24 21:39:43 +01:00
Senén Rodero Rodríguez
2993ef8707
Remove documents single uploads
2017-09-27 11:04:56 +02:00
Senén Rodero Rodríguez
c22637c349
Move method 'recover_documents_from_cache' from documentable controllers to document.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
88a7a29d27
Remove new_nested action from documents controller. Use cocoon gem to manage new nested fields creation on documents.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
824dd26d5a
User new direct uploads controllers action on documentable. Skipped spec.
2017-09-26 13:55:51 +02:00
BertoCQ
e4abe0d75a
Merge pull request #1849 from rockandror/documentable-fix
...
Documentable fix
2017-09-19 17:07:25 +02:00
Bertocq
e4e78c8f16
Rubocop autocorrections
2017-09-14 15:08:35 +02:00
Senén Rodero Rodríguez
4c225aac62
Remove document cached_attachment value after destroy_upload action.
2017-09-11 14:39:58 +02:00
Senén Rodero Rodríguez
15a4d26f39
Keep original filename for attachments
2017-09-01 13:08:34 +02:00
Senén Rodero Rodríguez
5581445fff
Use different path to store ajax uploaded cached attachments
2017-08-31 12:37:41 +02:00
Senén Rodero Rodríguez
6d66077a94
Make documentable capable to work with local or remote storage system.
2017-08-30 17:07:52 +02:00
Senén Rodero Rodríguez
5e6d1d799f
Use absolute urls on document cached_attachment
2017-08-30 15:50:32 +02:00
Senén Rodero Rodríguez
f4ac8b17d0
Store AJAX uploaded documents with timestamp prefix to avoid file name collision. Remove cached_attachments after document save.
2017-08-25 18:34:54 +02:00
Senén Rodero Rodríguez
0fbffdc73e
Fix abilities definition and related specs
2017-08-25 18:34:53 +02:00
Senén Rodero Rodríguez
cc89907bff
Add nested documents to proposal form.
2017-08-25 18:34:52 +02:00
Senén Rodero Rodríguez
e9c5f77368
Accept nested attributes for documents on proposals. Adapt documentable js file to allow many input files at the same page.
2017-08-25 18:34:51 +02:00
Senén Rodero Rodríguez
e327b420ff
Ajax file upload to tmp dir. Add cached_attachment to document. Recover image from cache. Add progress bar.
2017-08-25 18:34:51 +02:00
Senén Rodero Rodríguez
9a0b34fffe
Install jquery-file-upload assets for rails.
2017-08-25 18:34:51 +02:00
Senén Rodero Rodríguez
17ad148cd7
Fix i18n translations warnings.
2017-08-25 18:34:50 +02:00
Senén Rodero Rodríguez
a2130689ed
Create documentable concern and add it to budget investment model. Create documents controller, documents helper, routes, translations and specs
2017-08-25 17:27:37 +02:00
