9 Commits

Author	SHA1	Message	Date
Javi Martín	2ce3cfab5e	Remove @process instance variable ... Note we cannot name this variable `process` because in a controller spec the word `process` is a method, like `get` or `post`.	2019-09-30 16:43:10 +02:00
Javi Martín	5c81a70fa7	Use factory bot blocks to create complex data ... Having two questions, each of them with two comments, made the code hard to follow. Grouping the comments inside the block creating the questions makes it easier to know which comment belongs to which question, even if the code is still not 100% readable. We also remove instance variables, which by the way used the same variable name for two different things.	2019-09-30 16:43:10 +02:00
Javi Martín	91c21b0982	Remove instance variables in RSpec ... Instance variables might lead to hard-to-detect issues, since using a nonexistent instance variable will return `nil` instead of raising an error.	2019-09-30 16:43:10 +02:00
Javi Martín	f426b25fe5	Remove unneeded factories ... These factories were only used in one place and they even declared ID attributes. Using the comment factory with the `commentable` attribute does the same thing.	2019-09-29 22:52:53 +02:00
Javi Martín	adc5906253	Apply Rails/PluralizationGrammar rubocop rule	2019-09-10 21:43:38 +02:00
Javi Martín	f9ed186909	Add rubocop spacing rules ... We were following these rules in most places; we just didn't define them anywhere.	2019-09-10 21:04:56 +02:00
Javi Martín	488461b8ac	Remove consecutive blank lines	2019-09-10 20:02:15 +02:00
Javi Martín	bd85aede99	Use describe on new feature tests ... The `type: :feature` is automatically detected by RSpec because these tests are inside the `spec/features` folder. Using `feature` re-adds a `type: :feature` to these files, which will result in a conflict when we upgrade to Rails 5.1's system tests. Because of this change, we also need to change `background` to `before` or else these tests will fail. We're also adding a rubocop rule so we dont' accidentally add these keywords again.	2019-08-07 13:53:27 +02:00
German Galia	4f50e67ac3	Collaborative legislation summary	2019-06-03 12:34:25 +02:00