Commit Graph

56 Commits

Author SHA1 Message Date
Javi Martín
aec84f6522 Generate labels for attribute automatically
I'm not sure why it isn't already done by foundation's form builder. It
doesn't make any sense to change an ID of a form field without changing
the `for` attribute of its label.
2019-10-06 19:32:04 +02:00
Javi Martín
f8bd3d4f39 Extract links to signin and signup to methods 2019-10-05 14:07:24 +02:00
Javi Martín
f5d8badeb6 Extract partial to show "login to comment" message 2019-10-05 14:07:24 +02:00
Javi Martín
ae64458fce Use the same I18n key for "login to comment" text
We were using several different keys, all of them having the same
translations.
2019-10-05 14:07:23 +02:00
Javi Martín
71d9ddd849 Apply rule to end files with a newline character 2019-09-10 20:02:15 +02:00
Javi Martín
911fe4e481 Simplify calls to render partial
We're also adding a bit of consistency, since most of our calls to
partial rendering omit the `partial` and `locals` keys.
2019-09-04 15:00:36 +02:00
Javi Martín
3e4e65ead7 Use double quotes inside ERB
We were using single quotes inside ERB code when that code was inside
HTML double quotes.
2019-03-25 14:58:54 +01:00
Javi Martín
4c35df4812 Use double quotes inside string interpolation 2019-03-25 14:58:54 +01:00
Javi Martín
2b4e1cf358 Add missing double quotes
We overlooked a few single quotes while we changed thousands of them.
2019-03-25 13:22:35 +01:00
Julian Herrero
2b83be1c7c Use double quotes in app/views/legislation 2019-03-19 12:16:50 +01:00
decabeza
6f4f161076 Adds help gif on legislation processes with texts 2018-07-05 18:10:06 +02:00
decabeza
ee7ca37d18 Removes unused css 2018-03-07 17:18:27 +01:00
Bertocq
553348eaad Convert phase to symbol before comparision for active dates 2017-09-05 16:18:36 +02:00
decabeza
827e4702a9 removes duplicated social share partial on legislation views 2017-08-16 13:40:46 +02:00
decabeza
a97130934a fixes text on publish comment button 2017-06-28 13:40:37 +02:00
Bertocq
6c386ffd95 Make comments count display optional using a variable on comments comment_tree partial 2017-06-26 19:23:49 +02:00
Bertocq
523988a291 Replace old open_phase? method for new phase/publication open? on Legislative Process 2017-06-13 22:04:36 +02:00
rgarcia
792b15b224 Merges annotations 2017-06-07 14:58:34 +02:00
decabeza
28e17b870c unifies styles and html code 2017-05-24 13:03:25 +02:00
decabeza
260df52a34 uses current css classes 2017-05-23 12:22:57 +02:00
Amaia Castro
3ab6adbb1b Refactor share buttons partial to use gem helper 2017-03-25 13:54:33 +01:00
Martín González
ea9d9728d8 Fix comment boxes login warning display 2017-03-10 19:12:39 +01:00
Amaia Castro
c7eaadb4b2 Show comment boxes for all annotations at the clicked point 2017-02-24 15:45:36 +01:00
Fernando Blat
16c365ca1d Improve social networks share text 2017-02-16 16:13:31 +01:00
Martín González
9962202b0d Invert share buttons layout 2017-02-15 19:47:58 +01:00
Amaia Castro
311388969d Changes annotations text for twitter share button 2017-02-14 18:15:01 +01:00
Amaia Castro
2efa72ddd5 Merge branch 'legislation-module-stable' into 107-social-share-for-annotations 2017-02-14 18:14:00 +01:00
Martín González
af52fb5670 Improve social share buttons position for the annotations index and specific annotations 2017-02-14 17:11:02 +01:00
Amaia Castro
58b9135c71 Add context to annotation in index view 2017-02-13 11:18:33 +01:00
Amaia Castro
8e741a6b4f Refactor and use first node start + quote + last node end for the context 2017-02-13 09:53:36 +01:00
Amaia Castro
b298fb7316 Show annotation context in annotation page
Only works with quotes within the same html node for now
2017-02-10 15:35:42 +01:00
Amaia Castro
d656de680d Social share buttons for annotation 2017-02-09 15:32:42 +01:00
Amaia Castro
d65f1998d0 Sort comments in sidebar by number of votes 2017-02-09 12:42:00 +01:00
Fernando Blat
63a986d31c If the comment has errors, show the textarea with the error message 2017-01-20 18:35:34 +01:00
Fernando Blat
3d8724b13b Remove unnecessary hidden fields 2017-01-20 18:33:07 +01:00
Fernando Blat
2a5d21f8d4 Focus on textarea when showing the comments box 2017-01-20 18:28:15 +01:00
Amaia Castro
47b35a8149 Add spec for publishing a comment from the comments box for a draft 2017-01-20 11:42:14 +01:00
Amaia Castro
1af047089f Add form to publish a new first level comment from the comments box 2017-01-19 15:42:50 +01:00
Amaia Castro
536784ee04 Merge pull request #72 from medialab-prado/back-improvements
Back improvements
2017-01-19 10:27:12 +01:00
Martín González
076c5d2784 Use the full width key dates html where is possible, fix svg margin 2017-01-18 13:05:16 +01:00
Fernando Blat
dbbbf34b60 Link to the comment using an anchor 2017-01-18 11:26:38 +01:00
Fernando Blat
e7c754a875 Limit to 5 the number of comments.
Strip comments length
2017-01-18 11:25:05 +01:00
Amaia Castro
4b04b93f50 Show only first level comments in comments box for annotations 2017-01-17 17:40:04 +01:00
Fernando Blat
5c3f87c4a2 Merge pull request #70 from medialab-prado/reorganize-locale-files
Change comments texts in legislation questions
2017-01-17 16:39:08 +01:00
Amaia Castro
53e9837db3 Change texts for legislation questions comments 2017-01-17 15:42:42 +01:00
Amaia Castro
327fa6bce5 Remove link to non existing comments 2017-01-17 10:47:33 +01:00
Amaia Castro
30cb7fe7b4 Fix link 2017-01-17 10:47:33 +01:00
Amaia Castro
65fcd83ee5 Don’t show new annotation/comment form if allegations phase is not open 2017-01-16 19:06:06 +01:00
Fernando Blat
046c021c0c Complete create comment details 2017-01-14 16:43:40 +01:00
Fernando Blat
f47cef5a93 Highlight text when creating a comment 2017-01-14 16:43:26 +01:00