Commit Graph

43 Commits

Author SHA1 Message Date
Javi Martín
aec84f6522 Generate labels for attribute automatically
I'm not sure why it isn't already done by foundation's form builder. It
doesn't make any sense to change an ID of a form field without changing
the `for` attribute of its label.
2019-10-06 19:32:04 +02:00
Javi Martín
8d9cb4d8e3 Simplify generating checkboxes in forms
Using the block syntax to generate the label with a <span> tag inside
isn't necessary after upgrading foundation_rails_helpers. Before the
upgrade, we couldn't do so because the <span> tag was escaped.
2019-10-06 19:32:04 +02:00
Javi Martín
3ea9f3cecf Simplify generating form fields with labels
Instead of generating the label and then a field without a label, we can
directly generate a field with a label.
2019-10-05 16:01:58 +02:00
Javi Martín
f9ed186909 Add rubocop spacing rules
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Julian Herrero
f6489bc604 Use double quotes in app/views 2019-03-19 12:33:07 +01:00
Bertocq
10d780ea4b Add valuation flag to comment form cache key 2018-01-31 22:26:03 +01:00
Bertocq
0f4d0b4fe9 Improve valuation flag at comment form 2018-01-31 17:19:26 +01:00
Bertocq
149c81371b Allow valuation internal comments to be created
How:

Using a local variable at partials to set a hidden true/false value for
`valuation` parameter on the comment creation form.

Allowing that new param at the comment controller and using it when
building a new Comment.
2018-01-31 02:03:02 +01:00
rgarcia
2b52d26d82 refactors notifications into concerns and shared examples 2017-12-14 16:15:30 +01:00
Amaia Castro
53e9837db3 Change texts for legislation questions comments 2017-01-17 15:42:42 +01:00
Alberto Garcia Cabeza
3b28b56c5c improves html structure for comments 2016-12-28 14:36:06 +01:00
Alberto Garcia Cabeza
9dce52a69a Adds title on input checkboxes 2016-03-14 19:32:49 +01:00
Alberto Garcia Cabeza
3752f3a53b Adds foundation 6 🎉 2016-02-26 19:33:33 +01:00
Juanjo Bazán
48b3e8c450 removes commentable dependency from comment form 2015-09-12 14:12:37 +02:00
kikito
2d3015703d replaces constants by class methods + private functions. Fixes broken tests 2015-09-10 13:02:21 +02:00
kikito
8c9f189d75 merges master and fixes conflicts 2015-09-09 19:36:23 +02:00
kikito
ada03c8474 Adds max lengths in views 2015-09-09 18:34:26 +02:00
Juanjo Bazán
e4e1c9039f cache for comment/_form
uses info for commentable but without need for invalidation after commentable updates
2015-09-09 14:54:01 +02:00
kikito
601323b5a3 removes cache from comment form 2015-09-07 10:50:03 +02:00
Juanjo Bazán
e618c12344 removes weird char 2015-09-06 21:55:33 +02:00
rgarcia
d8f8dc826b updates comment form cache 2015-09-06 14:22:46 +02:00
rgarcia
5200d76be6 caches comments 2015-09-05 22:02:51 +02:00
Juanjo Bazán
dee2d0196b ancestries
moves to ancestry from acts_as_commentable_with_threading
2015-09-02 19:23:09 +02:00
Juanjo Bazán
eb689d7c7e refactors comment form 2015-09-02 17:22:21 +02:00
Juanjo Bazán
fc8687a707 adds comments labels per comment
fixes #265
2015-08-28 14:30:52 +02:00
Juanjo Bazán
030fd49120 allows comment as moderator/administrator
Ref: #170
2015-08-24 18:17:04 +02:00
Alberto Garcia Cabeza
dffb8e8a5e Adds styles for comment as administrator 2015-08-24 12:29:35 +02:00
Alberto Garcia Cabeza
cfd25042b6 Adds styles for comment as moderator 2015-08-24 12:22:31 +02:00
Alberto Garcia Cabeza
04db8112b4 Adds styles for associations comments 2015-08-19 11:53:35 +02:00
rgarcia
f31ed2940d adds moderation to comments and debates [#136] 2015-08-17 13:39:31 +02:00
Juanjo Bazán
8d87a69e0f hides comment forms from not logged users
Closes #66
2015-08-05 14:12:58 +02:00
rgarcia
cd2d05e0c5 fixing conflicts [#47] [#47] 2015-07-30 18:19:38 +02:00
kikito
c495d4678c merges master and fixes conflicts 2015-07-29 17:13:09 +02:00
kikito
c71182f6a6 Adds classes to several buttons so they don't look ugly 2015-07-29 12:54:51 +02:00
rgarcia
3247180dfa responds with ajax to comment creation [#47] 2015-07-28 20:32:53 +02:00
rgarcia
90f476f8d1 Merge branch 'master' into home 2015-07-27 23:30:46 +02:00
rgarcia
cc3f151914 fixing conflicts 2015-07-27 23:29:32 +02:00
rgarcia
baaf9cac93 refactors duplicate form id scenario [#21] 2015-07-27 22:50:38 +02:00
rgarcia
dea2964f08 fixes duplicate id in comment form [#21] 2015-07-27 22:22:12 +02:00
Alberto García Cabeza
c0a5200c10 Adds styles for debates show 2015-07-27 22:01:13 +02:00
rgarcia
b674e109a5 adds appropriate text for comment replies 2015-07-25 18:56:52 +02:00
rgarcia
3cec9b98f2 adds hide/show behaviour to comment forms 2015-07-25 18:49:00 +02:00
rgarcia
98463e4930 adds comments to debates [#7] 2015-07-18 17:38:57 +02:00