Javi Martín
35143ac43e
Use be_empty instead of not_to include
...
Using `not_to include` does not test for other elements which could be
present in the array.
2019-09-29 23:57:35 +02:00
Javi Martín
fd1325768f
Check exact array contents instead of inclusion
...
We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.
2019-09-29 23:57:35 +02:00
Javi Martín
7b0771106e
Remove isolated useless assignments
...
These variables are not surrounded by other assignments, and so they can
safely be removed without making it harder to read the code vertically.
2019-09-25 12:43:44 +02:00
Javi Martín
ffc50246c2
Apply explict RSpec/DescribedClass rubocop rule
...
We settled on using this style in commit 4cbe81a1
2019-09-23 16:51:00 +02:00
Senén Rodero Rodríguez
02be0c61f9
Add proposal translations
...
Adapt retire form to include needed translations and move validations
from controller to model.
Also change sanitizable concern to sanitize not marked for destruction
translations.
2019-06-27 09:19:36 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Julian Herrero
ab1e9a9310
Fix typo
2019-01-14 18:48:31 +01:00
María Checa
f1e7b634ba
Adds moderate actions to proposal system notifications
2018-07-26 17:55:06 +02:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
1441de5107
Enable RSpec/HookArgument cop and fix issues
...
To be consistent about before/after arguments, as `:each` or `:example`
are same and default scopes, best not to send an argument in those
scenarios.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
2018-01-07 02:07:19 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
265d4d0967
Enables RSpec/DescribedClass cop & fixes all issues
...
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
2018-01-07 00:38:19 +01:00
Bertocq
70f2ee0cf5
Fix Time.now usage to Time.current to include zone
2017-12-16 17:59:16 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
Alberto Miedes Garcés
ad8aba0739
Revised public fields, wrote more exhaustive specs
2017-05-15 20:22:11 +02:00
Alberto Miedes Garcés
074a8182f6
Add ProposalNotification to api
2016-12-29 10:58:40 +01:00
rgarcia
8e12fbdd55
adds time limit between notifications
2016-06-07 13:48:09 +02:00
rgarcia
f5375e813d
stores a proposal notification
2016-06-01 17:23:56 +02:00
