Javi Martín
fd1325768f
Check exact array contents instead of inclusion
...
We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.
2019-09-29 23:57:35 +02:00
Javi Martín
f27beb1e47
Simplify testing array contents
...
We were testing for the size and the content of the elements when we
could test for the array itself.
2019-09-24 21:32:52 +02:00
Javi Martín
ffc50246c2
Apply explict RSpec/DescribedClass rubocop rule
...
We settled on using this style in commit 4cbe81a1
2019-09-23 16:51:00 +02:00
Javi Martín
58ba517717
Apply RSpec/ExampleWording rubocop rule
2019-09-10 21:43:39 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
voodoorai2000
7917cea676
Change to_not for not_to
...
Eventhough some of us sentimentals still like the syntax `to_not` the current trend is to move to the new syntax `not_to`.
In this commit we are updating the references of expectations that used `to_not` to `not_to`.
2018-12-15 12:33:28 +01:00
rgarcia
09c44ee583
Extend notifications to be marked as read and unread
2018-03-23 11:47:06 +01:00
Bertocq
c4aa2d7093
Enable RSpec/MessageExpectation cop & fix issues
...
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
2018-01-07 16:36:18 +01:00
Bertocq
265d4d0967
Enables RSpec/DescribedClass cop & fixes all issues
...
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
2018-01-07 00:38:19 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
rgarcia
8c85611ec9
Adds missing specs for notification titles
2017-12-11 13:23:30 +01:00
rgarcia
e2689d640c
refactors notification helpers
2016-06-15 12:12:56 +02:00
Juanjo Bazán
704a038795
groups notifications
2016-01-08 14:32:16 +01:00
rgarcia
e2f419e625
destroy notifications when marked as read
2016-01-07 12:02:01 +01:00
rgarcia
b5e9113718
merges activities into notifications
2016-01-06 12:33:37 +01:00
Julian Herrero
9a5f525dc9
marcar notificaciones como leidas despues de ser vistas
2016-01-05 17:43:44 +01:00
Julian Herrero
d9ba3edc2a
mostrar notificaciones a los usuarios cuando alguien comenta en su
...
debate o responde a su comentario
2016-01-05 17:43:44 +01:00
