Commit Graph

63 Commits

Author SHA1 Message Date
Javi Martín
5ff1162038 Simplify creating follows in specs
While in theory we wouldn't need to use the `transient` nor the
`after(:create)` because there's already a `has_many :through`
association with followers, Factory Bot / ActiveRecord don't
automatically associate the followable, resulting in an invalid record
exception.
2019-09-30 13:34:31 +02:00
Javi Martín
aeb1655961 Use budget phase traits
We were already using them in many places, but not everywhere.
2019-09-24 21:34:06 +02:00
Javi Martín
f9ed186909 Add rubocop spacing rules
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
voodoorai2000
a932737881 Delete ballots 2019-05-31 15:43:06 +02:00
Javi Martín
307cf24846 Use describe on feature tests
The `type: :feature` is automatically detected by RSpec because these
tests are inside the `spec/features` folder. Using `feature` re-adds a
`type: :feature` to these files, which will result in a conflict when we
upgrade to Rails 5.1's system tests.

Because of this change, we also need to change `background` to `before`
or else these tests will fail.
2019-05-28 16:36:54 +02:00
decabeza
eda6ea7f12 Merge branch 'master' into dashboard 2019-03-26 16:45:48 +01:00
Julian Herrero
c82b2a975a Add new settings tab for participation processes
- Rename setting keys
- New tab por participation processes
- Hide these settings from features tab
2019-03-19 19:45:32 +01:00
Julian Herrero
8ae80cd1a1 Cleanup (remove unnecessary code) 2019-03-19 15:11:50 +01:00
Julian Herrero
31ac8b7f55 Change single quotes to double quotes 2019-02-15 11:40:39 +01:00
Juan Salvador Pérez García
e5f9cf6710 Fixed #239
Proposals dashboard refactored to dashboard.
Added missing specs for the dashboard.
2018-07-24 15:52:43 +02:00
rgarcia
225166a5eb Remove focus from specs 2018-07-15 13:58:32 +02:00
rgarcia
88cde6d018 Deal gracefully with hidden followable in my activity
We were seeing an exception when a user was following a proposal and
that proposal becomes hidden

With this commit we are skipping this proposals and hopefully fixing
this exception

We are also adjusting the count of followed proposals, without
including hidden proposals. It might be cleaner, to remove a `Follow`
when its `Followable` becomes hidden. But then we should probably
activate the `Follow` again if the `Followable` becomes non-hidden…

For now this commit should suffice 😌
2018-07-10 17:50:51 +02:00
decabeza
ee884ed998 Updates active to is-active class for menus 2018-06-06 12:01:16 +02:00
Angel Perez
122b17033b Use Selenium API to accept/dismiss JS modals/browser alerts
JS modals/browser alerts are not automatically accepted now with
Selenium, events that trigger such events must be wrapped in one
of the following methods: `accept_alert`, `accept_confirm` or
`dismiss_confirm`
2018-03-27 14:47:49 -04:00
Raimond Garcia
8bec36500a Merge pull request #2385 from wairbut-m2c/2363-alert-delete-investment-project
Add alert message when a user deletes an investment project from "My activity"
2018-02-13 14:06:08 +01:00
Bertocq
c0dcd03bab Prevent valuation comments from appearing in public pages 2018-01-31 18:14:11 +01:00
iagirre
b3dec1897e Feature spec to test that the budget_investment is not been deleted if the user dismisses the confirm dialog 2018-01-25 16:54:26 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
decabeza
377a1d9f01 improves following view and updates specs 2017-12-07 16:31:05 +01:00
decabeza
83c23c35c4 changes title text for public interests list 2017-12-06 15:40:50 +01:00
decabeza
2148ee7492 updates texts on specs 2017-10-18 19:37:20 +02:00
taitus
9b6b57a24c Remove all white spaces 2017-09-06 14:12:32 +02:00
BertoCQ
cf3dbc8149 Merge pull request #1769 from rockandror/empty-user-interests
Add empty interests list message.
2017-07-26 18:31:14 +02:00
Senén Rodero Rodríguez
3370896ead Add empty interests list message. 2017-07-26 17:48:47 +02:00
Bertocq
7d406cae76 Rubocop autocorrections 2017-07-25 13:01:03 +02:00
taitus
cef67c50a8 Increased test coverage to Following user public page. 2017-07-13 20:33:58 +02:00
Senén Rodero Rodríguez
4b2310c135 Move and refactor method from follow to user model to get user interests. Add specification to check the discard of duplicate interests. 2017-07-07 15:18:34 +02:00
taitus
e54e33f296 Use display in followable shared specs names when referring to DOM elements renderization. Add whitespace to proposal page. 2017-07-07 13:38:53 +02:00
taitus
35f7f11177 Add dependent destroy to followable. 2017-07-07 13:37:55 +02:00
taitus
19820e4432 Add public interests validation and show interests on user profile 2017-07-07 13:34:43 +02:00
Bertocq
798b646135 Cleanup Settings values modified after specs are run 2017-06-07 20:55:42 +02:00
Juanjo Bazán
053a3e7b41 makes user page to show only active feature comments 2017-01-10 21:28:04 +01:00
kikito
cb7ea79aaf Replaces spending proposals by budget investments in user/show 2016-09-09 12:19:38 +02:00
rgarcia
d5453f1733 fixes spec 2016-03-29 17:36:31 +02:00
Juanjo Bazán
b660702787 specifies permission the right way 2016-03-14 14:36:13 +01:00
Juanjo Bazán
c09e6f95d7 users can now delete their own spending proposals
via the 'my activity' page
2016-03-14 12:53:00 +01:00
rgarcia
6221c70027 does not display spending proposals when filtering my activity 2016-02-21 21:35:10 +01:00
rgarcia
7699b99655 allows authors and admins to view their spending proposals in my activity 2016-02-21 18:02:55 +01:00
Juanjo Bazán
19212a6b46 fixes 'My activity' comments count for admins/mods 2015-11-17 19:40:18 +01:00
Juanjo Bazán
1ca7ca6e05 hides comments posted as mod/admin from user page 2015-11-12 12:22:21 +01:00
Juanjo Bazán
a881ced801 adds user's email to activity page for admins 2015-11-12 12:04:34 +01:00
Juanjo Bazán
b1ea8f7938 increases coverage of user page 2015-11-05 16:39:09 +01:00
Juanjo Bazán
f57eef4929 makes public activity toggleable 2015-11-04 13:51:31 +01:00
Juanjo Bazán
6d26901f9f adds specs for user's page 2015-11-03 20:26:13 +01:00
Juanjo Bazán
8c4444985f renames spec 2015-11-03 20:18:00 +01:00
Alberto Garcia Cabeza
2bf6603207 Merges master and fixes conflicts 2015-10-28 12:51:23 +01:00
Alberto Garcia Cabeza
abad54d01a Updates tests with new texts 2015-10-28 12:47:51 +01:00
Alberto Garcia Cabeza
120b1a65c2 Changes tests for new texts 2015-09-12 18:13:52 +02:00
rgarcia
30073ca820 fixes spec 2015-09-07 01:04:53 +02:00
Juanjo Bazán
8037248b73 marks social network login specs as pending
temporary, for the beta testing phase
2015-09-01 12:56:15 +02:00