Javi Martín
1973c61552
Simplify creating notifications in specs
2019-09-30 14:10:46 +02:00
Javi Martín
7b0771106e
Remove isolated useless assignments
...
These variables are not surrounded by other assignments, and so they can
safely be removed without making it harder to read the code vertically.
2019-09-25 12:43:44 +02:00
Javi Martín
eb7a052207
Simplify tests using delayed_job
...
Among other advantages, now we can run these tests with
`rspec --tag delayed_jobs`.
2019-09-23 13:47:45 +02:00
Javi Martín
044eabd7ef
Apply Rspec/LetSetup rubocop rule
2019-09-10 21:43:39 +02:00
voodoorai2000
d0b8fef6b3
Delete spending proposals
2019-05-31 18:22:59 +02:00
Javi Martín
307cf24846
Use describe on feature tests
...
The `type: :feature` is automatically detected by RSpec because these
tests are inside the `spec/features` folder. Using `feature` re-adds a
`type: :feature` to these files, which will result in a conflict when we
upgrade to Rails 5.1's system tests.
Because of this change, we also need to change `background` to `before`
or else these tests will fail.
2019-05-28 16:36:54 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
voodoorai2000
7917cea676
Change to_not for not_to
...
Eventhough some of us sentimentals still like the syntax `to_not` the current trend is to move to the new syntax `not_to`.
In this commit we are updating the references of expectations that used `to_not` to `not_to`.
2018-12-15 12:33:28 +01:00
decabeza
d58941ef9c
Updates text on notifications spec
2018-07-26 17:55:06 +02:00
María Checa
b7a1599fdf
Adds logic to send proposal notifications in batches
...
WIP batches tests
2018-07-26 17:55:06 +02:00
Bertocq
c0feabd71e
Try if notifiable has notifiable methods
...
Why:
There are Notifications with associated `notifiables` that actually are
not anymore Notifiables (the class doesn't include the Notifiable
concern). So when Notification delegates certain "notifiable" methods
to them the is an error.
How:
Using `try` directly on the notifiable association to avoid the delegate
trap on those corner case scenarios.
2018-07-26 10:33:04 +02:00
Bertocq
e010f95485
Increase notifications spec with AdminNotification scenarios
2018-07-25 18:33:45 +02:00
Bertocq
c4049efa4a
Fix notification expectations for read ones
2018-03-28 09:19:58 +02:00
rgarcia
09c44ee583
Extend notifications to be marked as read and unread
2018-03-23 11:47:06 +01:00
Bertocq
7f14544f71
Enable Capybara/CurrentPathExpectation cop & fix issues
...
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule
On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
2018-01-06 23:31:41 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
rgarcia
e3c8dece8f
Makes the code aware of notifications for hidden commentables
2017-12-11 13:22:10 +01:00
Bertocq
cd66ba5d54
Rubocop autocorrections
2017-11-13 02:22:00 +01:00
decabeza
45133a917f
adds topic notifications specs
2017-10-20 17:07:44 +02:00
Senén Rodero Rodríguez
bb4e4dc084
Fix almost all broken specs
2017-08-01 16:28:01 +02:00
Bertocq
dd54be111d
Fix follower notifications flaky spec
2017-07-11 18:08:58 +02:00
taitus
b29bf62f56
Send proposals notifications to followers.
2017-07-07 13:37:55 +02:00
Amaia Castro
3009706b0d
Don’t allow comments on questions for unverified users and when the phase is closed
2017-02-08 18:19:10 +01:00
Amaia Castro
289b8e044b
Fix url to notifiable when it is a Legislation Question or Annotation
2017-01-20 18:46:57 +01:00
rgarcia
24bc8cca20
runs all specs
2016-08-03 20:56:33 +02:00
rgarcia
4f4a5b68e5
runs all spec file
2016-08-03 20:50:37 +02:00
rgarcia
3b5e0b55c0
tries to fix flacky spec
2016-08-03 20:45:36 +02:00
rgarcia
a0ddde16e9
adds notifications for proposals
2016-06-07 22:03:14 +02:00
Juanjo Bazán
704a038795
groups notifications
2016-01-08 14:32:16 +01:00
rgarcia
e2f419e625
destroy notifications when marked as read
2016-01-07 12:02:01 +01:00
Julian Herrero
d9ba3edc2a
mostrar notificaciones a los usuarios cuando alguien comenta en su
...
debate o responde a su comentario
2016-01-05 17:43:44 +01:00
