Javi Martín
f9ed186909
Add rubocop spacing rules
...
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Javi Martín
71d9ddd849
Apply rule to end files with a newline character
2019-09-10 20:02:15 +02:00
Javi Martín
286e0ca878
Handle AccessDenied in management sessions
...
We were raising a `CanCan::AcessDenied` and were getting a 500 Internal
Server Error.
I've chosen to do the same thing we do in the ApplicationController.
There are other options to handle this request, like redirecting to the
login page or returning a 401 Unauthorized HTTP status.
2019-04-25 20:36:50 +02:00
Julian Herrero
6e88031537
Fix several rubocop warnings
...
Metrics/LineLength: Line is too long.
RSpec/InstanceVariable: Use let instead of an instance variable.
Layout/TrailingBlankLines: Final newline missing.
Style/StringLiterals: Prefer double-quoted strings.
2019-04-17 17:40:56 +02:00
rgarcia
9a49716f22
updates controller specs deprecation warnings
2019-04-17 17:40:55 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
c9bc028524
Remove all unnecesary extra spacing and Layout/ExtraSpacing list from rubocop file
2017-06-28 14:12:51 +02:00
Bertocq
2fa92937d2
Fix all Style/BracesAroundHashParameters rubocop issues and remove them from rubocop_todo list
2017-06-28 14:12:51 +02:00
Bertocq
9763931f55
Fix all Layout/SpaceBeforeComma rubocop issues and remove from rubocop_todo list
2017-06-26 17:57:53 +02:00
Juanjo Bazán
d1e50d70d6
managers can login to /management
2016-05-10 19:10:02 +02:00
Juanjo Bazán
2eabab657a
allows admin to sign in into management
2016-04-27 17:26:19 +02:00
Juanjo Bazán
97dcd02750
adds spec for management's managed user logout
2015-10-23 13:48:50 +02:00
Juanjo Bazán
f1bc7af462
makes manager logout to remove session user data
2015-10-23 13:37:19 +02:00
Juanjo Bazán
5ee95a7b5b
adds spec for managed_user
2015-10-23 13:17:03 +02:00
Juanjo Bazán
89cc26c261
adds managers login via ManagerAuthenticators
2015-10-15 15:57:53 +02:00
rgarcia
a42439cbd2
fixes specs
2015-10-12 14:06:24 +02:00
rgarcia
1a89c5d147
adds specs for managed user session
2015-10-11 16:58:55 +02:00
Juanjo Bazán
742ea1bd2e
adds management/sessions controller
2015-10-01 17:53:15 +02:00