grecia

consul/grecia

Fork 0

Commit Graph

Author	SHA1	Message	Date
Javi Martín	6ea9383743	Allow toggling elements with the keyboard Using `<a>` tags with no `href` means these elements cannot be activated by keyboard users, so we're replacing them with buttons. In the future we probably want to add more consistency so all toggle buttons use the same code. We might also add styles depending on the `aria-expanded` property.	2021-03-31 13:38:38 +02:00
Javi Martín	31b65679c3	Extract partial to render flag actions The main obstacle to extract this partial was probably the paths for the flag and unflag actions. Now that we use Rails 5.1 `resolve` method to handle nested resources, we can use `polymorphic_path`. Also note the code is a bit ugly because comments render a divider. We should probably use a CSS border instead. Co-Authored-By: taitus <sebastia.roig@gmail.com>	2020-07-07 23:39:21 +02:00

Author

SHA1

Message

Date

Javi Martín

6ea9383743

Allow toggling elements with the keyboard

Using `<a>` tags with no `href` means these elements cannot be activated
by keyboard users, so we're replacing them with buttons.

In the future we probably want to add more consistency so all toggle
buttons use the same code. We might also add styles depending on the
`aria-expanded` property.

2021-03-31 13:38:38 +02:00

Javi Martín

31b65679c3

Extract partial to render flag actions

The main obstacle to extract this partial was probably the paths for the
flag and unflag actions.

Now that we use Rails 5.1 `resolve` method to handle nested resources,
we can use `polymorphic_path`.

Also note the code is a bit ugly because comments render a divider. We
should probably use a CSS border instead.

Co-Authored-By: taitus <sebastia.roig@gmail.com>

2020-07-07 23:39:21 +02:00

2 Commits