Javi Martín
b51aa31e6a
Use HTML beautifier to indent ERB files
...
We had inconsistent indentation in many places. Now we're fixing them
and adding a linter to our CI so we don't accidentally introduce
inconsistent indentations again.
2025-03-07 16:31:08 +01:00
Javi Martín
629e208e9d
Add and apply ArgumentAlignment rubocop rule
...
We're choosing the default `with_first_argument` style because it's the
one we use the most.
2023-08-18 14:56:16 +02:00
Javi Martín
6a2c01b119
Extract method to render an admin table action
...
This way it will be easier to change the behavior of all table actions,
like adding ARIA attributes. In the past, when we changed the behavior
of the `link_to` method, we had to change all table action classes.
2021-09-20 20:27:37 +02:00
Javi Martín
26fed593df
Apply Style/RedundantInterpolation to ERB files
...
We forgot to do so in commit 469b39ffa
2021-09-03 11:49:53 +02:00
Javi Martín
663fba53db
Group admin search label translations together
...
Since there are two different labels/placeholders for poll officers and
also two different ones for users, we're only grouping one of each.
2020-12-21 18:25:45 +01:00
Javi Martín
0a3acf3c5f
Use a shared translation for search buttons
...
We were writing the same text over and over for the same translations.
Since they all serve the same function, it's perfectly fine for them to
have the same text, and so we can have a shared translation.
2020-12-04 19:57:05 +01:00
Javi Martín
8c1140a1bf
Use semantic HTML classes in table actions
...
Note the CSS could probably be improved to avoid duplication with other
button style definitions. However, that's fine because we're going to
change the style of the links soon.
For the same reason, I haven't bothered to style every single link the
way it was until now.
2020-11-03 14:58:02 +01:00
Javi Martín
fb23df2e5b
Allow additional links in table actions component
...
This way we'll be able to make these links consistent.
2020-10-21 13:19:49 +02:00
Javi Martín
e3753b1ad9
Allow custom options in links to actions
...
Some links were using options like `remote: true`.
2020-10-19 18:56:02 +02:00
Javi Martín
f76930aab6
Simplify URL to destroy a booth assignment
...
We can find the booth through the booth assignment, so we don't need to
pass it in the URL.
Since the parameter is in the URL and not sent through a form, we can
also use `params[:poll_id]` directly, and so we can reuse the
`load_poll` method.
2020-10-19 18:48:01 +02:00
Javi Martín
f9ed186909
Add rubocop spacing rules
...
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Javi Martín
c62da726b8
Apply SpaceAroundErbTag ERB Lint rule
2019-09-10 20:02:15 +02:00
Javi Martín
71d9ddd849
Apply rule to end files with a newline character
2019-09-10 20:02:15 +02:00
Javi Martín
911fe4e481
Simplify calls to render partial
...
We're also adding a bit of consistency, since most of our calls to
partial rendering omit the `partial` and `locals` keys.
2019-09-04 15:00:36 +02:00
Javi Martín
0b55097820
Remove system count from old booth assigments
...
This number was not the important one; the important one is the one
given by the recounts.
Note we're also removing the votes by date, since they're also system
votes.
2019-08-07 20:31:45 +02:00
Javi Martín
45376d1e49
Fix indentation
2019-08-07 20:31:45 +02:00
decabeza
bee616c878
Fixes manage assignments button overlapping
2019-04-03 22:28:19 +02:00
Javi Martín
3e4e65ead7
Use double quotes inside ERB
...
We were using single quotes inside ERB code when that code was inside
HTML double quotes.
2019-03-25 14:58:54 +01:00
Julian Herrero
e63a862882
Use double quotes in app/views/admin/poll
2019-03-19 12:16:50 +01:00
decabeza
ee16900d1b
Unifies styles and views for admin voting booths section
2018-07-31 12:54:12 +02:00
decabeza
6f324c6931
Unifies styles and views for admin polls
2018-07-31 12:48:01 +02:00
decabeza
abf0fe992e
Removes tablist and tab roles
2018-07-04 17:14:24 +02:00
decabeza
28a7c03c21
Adds data-tabs on admin poll booth assignments show
2018-06-08 15:15:46 +02:00
Alberto
f9940980b0
Merge pull request #2645 from wairbut-m2c/admin-form-improvements-backport
...
Admin form improvements
2018-06-07 17:44:38 +02:00
decabeza
6a812659c3
Adds missing tablist and tab roles
2018-06-06 12:01:17 +02:00
Angel Perez
2c37702298
Sort booths by name and enable pagination
2018-05-23 08:08:54 -04:00
iagirre
4b8a471d38
Specs added to test the functionality and some UI modified to make test pass
2017-10-30 16:50:25 +01:00
iagirre
1077e25b2b
Shifts are destroyed when a booths is unassigned. An alert appears if there are shifts, but it doesn't if there aren't.
2017-10-30 12:36:07 +01:00
iagirre
89425f50ef
First steps to destroy shifts when booth_assignments are destroyed
2017-10-27 14:57:32 +02:00
iagirre
b854d99248
Assign/Unassign button for expired polls is disabled
2017-10-27 13:10:10 +02:00
Bertocq
995289304e
Add booth location on booth assigment management list, plus poll links on list
2017-10-20 22:08:34 +02:00
Bertocq
9b70b90e6a
Fix texts for booth assignment management
2017-10-19 22:05:02 +02:00
Bertocq
085e6ecba4
Complete booth assigment create/destroy methods to work with ajax
2017-10-19 21:32:37 +02:00
Bertocq
ce25780f70
Use booth assigment partial correctly
2017-10-19 21:32:09 +02:00
Bertocq
68b7528bab
Complete booth assigment partial with assign/unassign buttons and status
2017-10-19 21:31:36 +02:00
Bertocq
ca9e807cd4
Add link to booth assignment management at poll booth assigments list
2017-10-19 21:30:57 +02:00
Bertocq
e6efd8ad7d
Remove assign/unassign booth to poll from poll booth assigments list
2017-10-19 20:54:42 +02:00
Bertocq
f8839434f7
Complete booth assignment view list without actions yet
2017-10-19 20:10:51 +02:00
Bertocq
45d91a7e50
Add Poll booth_assignments and :Poll::BoothAssignment manage routes, actions and views
2017-10-19 19:27:26 +02:00
rgarcia
b6e080abca
fixes alignment
2017-10-19 11:28:09 +02:00
rgarcia
39ebc5173a
displays recounts for a single booth
2017-10-19 11:28:09 +02:00
rgarcia
0499fb6fef
highlights result's tab
2017-10-19 11:28:09 +02:00
rgarcia
0e8dc55b1b
updates translations
2017-10-19 11:28:09 +02:00
rgarcia
34ee16a1c1
displays results for booth
2017-10-19 11:28:09 +02:00
María Checa
799e2475da
Polls booth assignments fixes
...
Poll booth preview now renders recounts tab by default instead of the officers one.
2017-10-02 11:08:18 +02:00
Bertocq
bf981ca828
Remove Booth Assignment officer totals and add final&system counts
2017-09-25 18:47:44 +02:00
Bertocq
f27fcc7f99
Replace FinalResult with TotalResult at admin BoothAssignment show
2017-09-19 00:45:13 +02:00
Bertocq
361e0efe00
Remove Poll Recount model and all usages
2017-07-23 23:29:24 +02:00
Juanjo Bazán
2b68f02b95
paginates booths
2017-02-14 19:09:31 +01:00
Juanjo Bazán
e04cc55eb7
shows add booth link only for not assigned booths
2017-02-14 16:07:34 +01:00
