consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,065 Commits 1 Branch 0 Tags
a38cdb4df33eaefb9f30f23ce7ced06743b94dbc
Commit Graph

15065 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Javi Martín
bf20c93e99 Remove legacy annotations JavaScript file 
This code isn't used since commit 54e59a8a.
 2019-09-11 01:56:27 +02:00
Javi Martín
457ec11e6d Remove unnecessary return false statements 
The `initialize` functions don't need to return anything, since their
returned value is never used.

Returning false is a common practice in jQuery to stop an event, but in
plain JavaScript methods it doesn't have any side effects.
 2019-09-11 01:56:27 +02:00
Javi Martín
36a557927a Remove unused variables 2019-09-11 01:56:27 +02:00
Javi Martín
0ef75ff199 Remove unused JavaScript banners code 
The banner `update_style` method isn't used since commit 82cb8d4c.
 2019-09-11 01:56:27 +02:00
Javi Martín
2af09d65c7 Remove unused JavaScript poll token code 
We don't load the token message since commit 585f9ea5, so the JavaScript
to show it wasn't doing anything anymore.
 2019-09-11 01:56:27 +02:00
Javier Martín
dca090d7a1 Merge pull request #3649 from consul/remove_ie8_code 
Remove code specific to Internet Explorer 8
 2019-09-11 01:42:34 +02:00
Javier Martín
4b7755791d Merge pull request #3637 from consul/remove_rubocop_rules 
Remove unused rubocop rules
 2019-09-10 23:05:27 +02:00
Javi Martín
738e9ebc8b Remove code specific to Internet Explorer 8 
Internet Explorer 9 was released eight years ago. Besides that, we don't
really support IE8 anyway, since we show a popup to IE8 users saying
we don't support it, we haven't maintained the IE8-specific CSS file for
years, and we don't test our JavaScript against IE8.
 2019-09-10 22:43:37 +02:00
Javi Martín
97ec8776ab Reduce severity of LineLength rule 
Since we're ignoring this rule in many places, we're marking it in a
different way so it's clear we're not as strict with this rule.
 2019-09-10 22:27:33 +02:00
Javi Martín
7e9e1be1aa Remove Bundler/InsecureProtocolSource rubocop rule 
Since we're using rubygems as the only source, this rule is not
necessary.
 2019-09-10 22:27:33 +02:00
Javi Martín
16b8bee140 Remove unused rspec rubocop rules 
We consider these rules either return false positives or we don't have a
strong opinion about them.
 2019-09-10 22:27:33 +02:00
Javi Martín
3fa3801a49 Remove unused rails rubocop rules 
We consider these rules either return false positives or we don't have a
strong opinion about them.
 2019-09-10 22:27:33 +02:00
Javi Martín
d639cd587a Remove unnecessary uniq calls 
The code `where(id: ids)` is equivalent to `where(id: ids.uniq)`.

Since Rails 5 uses `distinct` instead of `uniq` and in most cases where
we use `uniq` with `pluck` we should simply remove the `uniq` call (as
done in this commit), we're also removing the `Rails/UniqBeforePluck`
rubocop rule.
 2019-09-10 22:27:33 +02:00
Javi Martín
9fb1d7df31 Remove obsolete ScopeArgs rubocop rule 
This rule doesn't make sense with Rails 5 anymore, since breaking it
will raise an error.
 2019-09-10 22:27:33 +02:00
Javi Martín
ea17256e3a Remove gemspec rubocop rules 
We don't have a gemspec file, so we don't need these ones.
 2019-09-10 22:27:33 +02:00
Javi Martín
9d566a2250 Remove most performance rubocop rules 
For performance purposes, we need to find bottlenecks in our
application. Optimizing the performance of small methods doesn't make
the application faster.

I've kept a few cops because applying these ones IMHO make the code
easier to read.
 2019-09-10 22:27:33 +02:00
Javier Martín
274fd1af4d Merge pull request #3636 from consul/change_basic_rubocop_rules 
Change basic rubocop rules
 2019-09-10 22:27:08 +02:00
Javi Martín
2243809d2e Move basic RSpec rubocop rules to basic cops 
These are rules we were already applying.

We've excluded the `factories` folder for some rules because there's a
factory defining a `context` attribute, which rubocop thought was the
`context` RSpec keyword.
 2019-09-10 21:43:39 +02:00
Javi Martín
59e107e565 Apply RSpec/HookArgument rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
9541ce892c Apply Bundler rubocop rules 
We're not using the InsecureProtocolSource rule because I don't feel
it's necessary.
 2019-09-10 21:43:39 +02:00
Javi Martín
c05b9c2aac Apply Capybara/CurrentPathExpectation rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
969a4e21c9 Apply RSpec/RepeatedExample rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
044eabd7ef Apply Rspec/LetSetup rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
58ba517717 Apply RSpec/ExampleWording rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
0788925c1b Apply Rails/Validation rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
27c73c22ea Configure Rails/UnknownEnv rubocop rule 
We use staging and preproduction environments, which are not valid by
default.

This rule is useful because misspelling the name of an environment might
otherwise go unnoticed.
 2019-09-10 21:43:39 +02:00
Javi Martín
9fe8c47528 Apply Rails/SafeNavigation rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
daa86ca3fc Apply Rails/RequestReferer rubocop rule 2019-09-10 21:43:39 +02:00
Javi Martín
a5ba13b599 Apply Rails/Presence rubocop rule 2019-09-10 21:43:38 +02:00
Javi Martín
adc5906253 Apply Rails/PluralizationGrammar rubocop rule 2019-09-10 21:43:38 +02:00
Javier Martín
1821a18c61 Merge pull request #3631 from consul/add_spacing_rules 
Add rubocop spacing rules
 2019-09-10 21:42:44 +02:00
Javi Martín
f9ed186909 Add rubocop spacing rules 
We were following these rules in most places; we just didn't define them
anywhere.
 2019-09-10 21:04:56 +02:00
Javier Martín
c7f64f8493 Merge pull request #3629 from consul/rubocop_rules 
Apply Rubocop rules
 2019-09-10 20:48:30 +02:00
Javi Martín
f74971060b Apply SpaceInHtmlTag ERB Lint rule 2019-09-10 20:02:15 +02:00
Javi Martín
ee8426c5b5 Indent with spaces instead of tabs 2019-09-10 20:02:15 +02:00
Javi Martín
c62da726b8 Apply SpaceAroundErbTag ERB Lint rule 2019-09-10 20:02:15 +02:00
Javi Martín
24359f8152 Remove extra space in HTML tags 2019-09-10 20:02:15 +02:00
Javi Martín
488461b8ac Remove consecutive blank lines 2019-09-10 20:02:15 +02:00
Javi Martín
47b2c42a1d Apply IndentationConsistency rubocop rule 2019-09-10 20:02:15 +02:00
Javi Martín
e252d82cdb Apply IndentationWidth rubocop rule 2019-09-10 20:02:15 +02:00
Javi Martín
b5b07bccd3 Apply PercentLiteralDelimiters rubocop rule 2019-09-10 20:02:15 +02:00
Javi Martín
17c36c6c6c Apply NotToNot rubocop rule 2019-09-10 20:02:15 +02:00
Javi Martín
71d9ddd849 Apply rule to end files with a newline character 2019-09-10 20:02:15 +02:00
Javi Martín
347fc21cf0 Fix trailing whitespace 2019-09-10 19:21:03 +02:00
Javi Martín
cf9e36c767 Replace single quotes with double quotes 
Most of these quotes were in the dashboard branch before we added the
rule for double quotes.
 2019-09-10 19:21:03 +02:00
Javi Martín
5c5d798590 Don't use Include in rubocop configuration file 
The Rakefile and config.ru files are now included by default, and the
behaviour of `Include` changed in Rubocop 0.56.0 (see rubocop's pull
request 5882) so now it **only** includes the files defined there, while
in the past it included those files in addition to the default files.
 2019-09-10 19:21:02 +02:00
Javier Martín
48b128744c Merge pull request #3678 from consul/fix_nan_score 
Fix Infinity exceptions in hot score calculator
 2019-09-10 17:51:23 +02:00
Javier Martín
e25d0ebc44 Merge pull request #3684 from consul/dynamic_from_mailer 
Evaluate mailer from address at runtime
 2019-09-10 17:08:46 +02:00
Javier Martín
f18ed2c595 Merge pull request #3650 from consul/fix_votation_spec 
Fix flaky votation type specs
 2019-09-10 16:40:51 +02:00
Javi Martín
53abc57578 Fix Infinity exceptions in hot score calculator 
There was a rare case we've found on some Travis builds where the system
time suddenly moved back to the past a couple of tenths of a second,
meaning `Time.current - resource.created_at` returned a negative number,
which lead to a division by zero.
 2019-09-10 16:00:21 +02:00