grecia

consul/grecia

Fork 0

Commit Graph

Author	SHA1	Message	Date
Bertocq	ed16a78f42	Enables RSpec/ExampleWording and fixes all issues Both avoiding 'should' and repiting 'it' on the tests description improves reading them and also makes all descriptions consistent. Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording	2018-01-07 01:03:45 +01:00
Bertocq	de2816a6a5	Enable RSpec/BeforeAfterAll rule and fix all issues This cop tries to avoid state leaking between examples. The fixes done on the code don't follow the suggested path, since the usage of `before(:all)` was not really useful. By using RSpec's `let` method we achieve same goals but with much better and readable tests. Check Cop description at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll	2018-01-06 21:16:00 +01:00
Bertocq	8b063a1bc1	Create spec for the new settings migration rake task	2017-06-07 20:56:49 +02:00

Author

SHA1

Message

Date

Bertocq

ed16a78f42

Enables RSpec/ExampleWording and fixes all issues

Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording

2018-01-07 01:03:45 +01:00

Bertocq

de2816a6a5

Enable RSpec/BeforeAfterAll rule and fix all issues

This cop tries to avoid state leaking between examples. The fixes done on the code don't follow the suggested path, since the usage of `before(:all)` was not really useful. By using RSpec's `let` method we achieve same goals but with much better and readable tests.

Check Cop description at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll

2018-01-06 21:16:00 +01:00

Bertocq

8b063a1bc1

Create spec for the new settings migration rake task

2017-06-07 20:56:49 +02:00

3 Commits