consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,242 Commits 1 Branch 0 Tags
9694def11a94de68b1bed47e2dcee4fe14c65eb4
Commit Graph

15242 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Raimond Garcia
710e5ae965 Merge pull request #2949 from consul/i18n-language-names 
Display language name or language key
 2018-10-10 11:45:04 +02:00
voodoorai2000
59b35156b1 Fix flaky spec 
`I18n.available_locales=` does a little magic[1] and was causing some flakieness along the way, as the `:wl` locale persisted in future specs

Thanks for the heads up @javierm 👌

[1] https://www.rubydoc.info/github/svenfuchs/i18n/I18n%2FConfig:available_locales=
 2018-10-09 22:15:05 +02:00
voodoorai2000
6f978b9f4e Fix portuguese specs 2018-10-09 18:32:59 +02:00
decabeza
16acb2a65f Adds enable help page task 2018-10-09 13:01:43 +02:00
decabeza
4ea1f7732b Updates i18n on specs 2018-10-08 11:26:53 +02:00
dependabot[bot]
5e81977bc6 Bump letter_opener_web from 1.3.2 to 1.3.4 
Bumps [letter_opener_web](https://github.com/fgrehm/letter_opener_web) from 1.3.2 to 1.3.4.
- [Release notes](https://github.com/fgrehm/letter_opener_web/releases)
- [Changelog](https://github.com/fgrehm/letter_opener_web/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fgrehm/letter_opener_web/compare/v1.3.2...v1.3.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-10-08 06:11:38 +00:00
decabeza
775b4698be Moves all new styles to dashboard.scss 2018-10-05 18:52:04 +02:00
decabeza
e9a5580f9a Adds styles to dashboard mailing views 2018-10-05 18:45:58 +02:00
decabeza
d38ef88b06 Adds styles to dashboard poster views 2018-10-05 18:38:17 +02:00
dependabot[bot]
64574b9369 Bump rollbar from 2.15.5 to 2.18.0 
Bumps [rollbar](https://github.com/rollbar/rollbar-gem) from 2.15.5 to 2.18.0.
- [Release notes](https://github.com/rollbar/rollbar-gem/releases)
- [Changelog](https://github.com/rollbar/rollbar-gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollbar/rollbar-gem/compare/v2.15.5...v2.18.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-10-05 16:25:15 +00:00
dependabot[bot]
2cf5196239 Bump cancancan from 2.1.2 to 2.3.0 
Bumps [cancancan](https://github.com/CanCanCommunity/cancancan) from 2.1.2 to 2.3.0.
- [Release notes](https://github.com/CanCanCommunity/cancancan/releases)
- [Changelog](https://github.com/CanCanCommunity/cancancan/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/CanCanCommunity/cancancan/compare/2.1.2...2.3.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-10-05 16:24:14 +00:00
Raimond Garcia
3e6b87df04 Merge pull request #2906 from consul/dependabot/bundler/i18n-tasks-0.9.25 
Bump i18n-tasks from 0.9.20 to 0.9.25
 2018-10-05 18:23:19 +02:00
Raimond Garcia
6a769d9484 Merge pull request #2926 from consul/dependabot/bundler/rubocop-rspec-1.26.0 
Bump rubocop-rspec from 1.24.0 to 1.26.0
 2018-10-05 18:22:33 +02:00
Raimond Garcia
4084b1c59f Merge pull request #2927 from consul/dependabot/bundler/delayed_job_active_record-4.1.3 
Bump delayed_job_active_record from 4.1.2 to 4.1.3
 2018-10-05 18:22:09 +02:00
Raimond Garcia
64997329fe Merge pull request #2928 from consul/dependabot/bundler/browser-2.5.3 
Bump browser from 2.5.2 to 2.5.3
 2018-10-05 18:21:42 +02:00
Raimond Garcia
3fc9e52099 Merge pull request #2929 from consul/dependabot/bundler/jquery-rails-4.3.3 
Bump jquery-rails from 4.3.1 to 4.3.3
 2018-10-05 18:21:23 +02:00
decabeza
9488afa1fd Updates i18n 2018-10-05 18:19:56 +02:00
decabeza
b7c3a918e3 Updates js class name and id name 2018-10-05 18:18:42 +02:00
decabeza
fcb6e67ced Adds styles to proposals views 2018-10-05 18:10:10 +02:00
voodoorai2000
ad51109149 Remove duplicate language translation 2018-10-05 18:08:48 +02:00
voodoorai2000
168ebe3c8b Fix i18n task' specs 
Add i18n.yml to i18n task's available translation files
 2018-10-05 18:08:47 +02:00
voodoorai2000
9d7042c5ae Adds missing language name translations 2018-10-05 18:08:47 +02:00
voodoorai2000
66c9f6711b Removes obsolete locale keys for language names 2018-10-05 18:08:47 +02:00
voodoorai2000
0a0261900c Display language name or language key 
There where two issues with the current implementation:

- There was a possible duplication between looking up the language name in key "locale" and in key "i18n.language.name"

- The "default" option was not being picked up, as the fallback always returned the default locale's translation, "English"

With this implementation there is only a single place to put the language name: i18n.language.name. I think this place is easier to find and understand for Crowdin translators than a "locale" key hidden in general.yml

If the translation is not found we display the language key, instead of English, which makes more sense to me too 😌

Solution based on recent comments[1] on a related I18n issue

[1] https://github.com/svenfuchs/i18n/issues/365#issuecomment-419263847
 2018-10-05 18:08:41 +02:00
decabeza
aaaaa00807 Adds styles to dashboard layouts, progress, show and partials 2018-10-05 18:04:30 +02:00
decabeza
57b9f54647 Adds styles to dashboard menu 2018-10-05 17:55:42 +02:00
decabeza
f3ca53c698 Adds styles to dashboard polls views 2018-10-05 17:53:07 +02:00
decabeza
76ec44a810 Adds styles to communities views 2018-10-05 17:46:45 +02:00
decabeza
71c70b8324 Removes foundation icons font 2018-10-05 17:42:14 +02:00
Alberto
3771e6105e Merge pull request #2947 from jsperezg/fix_action_sorting 
Fixes action sorting
 2018-10-05 17:25:13 +02:00
Javier Martín
e4f99681f8 Merge pull request #2950 from consul/backport-improve_index_legislation_proposals 
Allow select winner legislation proposals
 2018-10-05 12:59:28 +02:00
Raimond Garcia
f68dc2e1a9 Merge pull request #2936 from consul/i18n-pluralize 
Avoid InvalidPluralizationData exception when missing translations
 2018-10-05 12:57:48 +02:00
Javier Martín
68709e6353 Merge pull request #2952 from consul/backport-update_custom_pages_translations 
Update custom pages translations
 2018-10-05 12:57:06 +02:00
voodoorai2000
be80973e44 Avoid InvalidPluralizationData exception when missing translations 
We work with many languages using Crowdin[1]

Sometimes translators forget to fill in all the necessary plural forms of a translation (zero, one, other) and in those cases we were seing the exception InvalidPluralizationData being raised

There are a number of approches to fix this... from being more strict when approving translations, to automatically extrapolating what those plural forms should be

For now, we've gone for a simple approach to display the actual count(0,1,2,3,4, etc) instead of the whole translation

So, if the plural form of "1 comment" is missing, just a "1" will be displayed and no exceptions raised

Note: The first two specs, test what is really Rails' functionalities. However as we are monkey patching the pluralize method, I thought it was appropriate to doble check it

[1]https://crowdin.com/project/consul
 2018-10-05 12:26:07 +02:00
Javi Martín
d03cc2dc95 Update Spanish locales 
Just like done with English locales when updating translatable custom
pages in commit 351ef99.
 2018-10-05 12:21:47 +02:00
Javi Martín
ea7d4e0996 Remove trailing whitespace 2018-10-05 12:21:37 +02:00
decabeza
0d8c9c289a Removes closed message on legislation proposals votes 2018-10-04 16:32:32 +02:00
Javi Martín
0945f046a3 Avoid using xpath in specs 
Using xpath is usually harder to read and more fragile.
 2018-10-04 16:31:00 +02:00
Javi Martín
959270b0bb Separate setup, actions and expections in specs 2018-10-04 16:31:00 +02:00
Javi Martín
4c84a3a854 Move logic from view to helper 2018-10-04 16:31:00 +02:00
Javi Martín
9c13f08c8e Show selected legislation proposals by default 2018-10-04 16:31:00 +02:00
Javi Martín
2a5a2e0fcb Use "Random" instead of "All" in proposals filters 
That way users might be less surprised when they see proposals are
different each time they access the page.
 2018-10-04 16:31:00 +02:00
Javi Martín
8976280493 Order selected proposals by confidence score 
The same way we order budget results.
 2018-10-04 16:31:00 +02:00
Javi Martín
d9410a132a Always show filters for legislation proposals 
As done in the rest of the application: we show the filters even if
there isn't any data to display.
 2018-10-04 16:31:00 +02:00
Javi Martín
2fb5fb5fb2 Add missing newline characters 2018-10-04 16:31:00 +02:00
Javi Martín
ec2b4fe7ff Use %w[] instead of %w{} 
As agreed when discussing our rubocop rules.
 2018-10-04 16:30:59 +02:00
Javi Martín
81871a56f8 Simplify legislation process specs 
We kill two birds with one stone and also make each line less than 100
characters long.
 2018-10-04 16:30:59 +02:00
Javi Martín
66fc49f9ed Ignore dynamically used I18n keys 2018-10-04 16:30:59 +02:00
Javi Martín
659a45af0a Seed some selected legislation proposals 2018-10-04 16:30:55 +02:00
Javi Martín
d6ff7e0f3f Simplify code 2018-10-04 16:29:01 +02:00