Javi Martín
db97f9d08c
Add and apply rubocop rules for empty lines
...
We were very inconsistent regarding these rules.
Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.
The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.
[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Javi Martín
7b0771106e
Remove isolated useless assignments
...
These variables are not surrounded by other assignments, and so they can
safely be removed without making it harder to read the code vertically.
2019-09-25 12:43:44 +02:00
rgarcia
f23fd6f3bb
Remove parameterise deprecation warning
...
DEPRECATION WARNING: Passing the separator argument as a positional
parameter is deprecated and will soon be removed. Use `separator: '_'`
instead.
2019-04-17 17:40:55 +02:00
Javi Martín
2b4e1cf358
Add missing double quotes
...
We overlooked a few single quotes while we changed thousands of them.
2019-03-25 13:22:35 +01:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Vicente Mendoza
295facccb1
Test to check that returns error when it comes to relate an investment content with itself.
2018-02-02 10:57:09 +01:00
María Checa
b2054ac531
Improved relationable tests for budget investments
2018-01-12 18:26:37 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
f6d23df862
Avoid using eval when send can do the job
2017-12-25 23:47:55 +01:00
Bertocq
2283237d44
Avoid Looking up factories by class is deprecated and will be removed in FactoryGirl 5.0
2017-12-25 23:46:51 +01:00
María Checa
1e23281c28
Fixed related content tests
2017-12-20 13:43:56 +01:00
Bertocq
f190d9c626
Fix related content score classname on specs
2017-12-20 03:06:53 +01:00
Bertocq
f21f5ec05e
Refactor Related Content Controller score methods
2017-12-20 02:36:13 +01:00
María Checa
8e4a39a066
Updated schema and fixed tests
2017-12-19 20:45:23 +01:00
María Checa
b99a2eac6f
Fixed tests
2017-12-19 19:10:43 +01:00
María Checa
03aaa82d86
Improved tests
2017-12-19 17:01:35 +01:00
María Checa
4192860a73
Added and improved related content tests
2017-12-18 23:56:44 +01:00
