consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
18,723 Commits 1 Branch 0 Tags
68285aae06c6b4fb1a4cb15b4534a3af4ae6fcc3
Commit Graph

18723 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Javi Martín
0658edbea2 Merge pull request #5395 from consuldemocracy/fix_new_window_typo 
Fix link to debates help
 2024-03-18 15:47:59 +01:00
Javi Martín
1a22db8b17 Fix link to debates help 
This link used to open in a new window, and we accidentally changed that
behavior while refactoring it in commit c2710de5f.

Since we're adding a test for this case, and the Proposals::NewComponent
class is similar, we're adding a test for that class too. In the case of
proposals, we need to sign in a user because the proposals form contains
fields to attach image, that currently rely on a user being signed in.
 2024-03-18 15:29:46 +01:00
Javi Martín
0972bcbbe9 Merge pull request #5422 from consuldemocracy/fix_polls_test 
Prevent "Unable to autoload constant" error in tests
 2024-03-18 15:28:26 +01:00
Javi Martín
c7ea55ae35 Merge pull request #5431 from consuldemocracy/rubocop_capybara_code_climate 
Update Code Climate Rubocop version
 2024-03-18 15:23:07 +01:00
Javi Martín
8ba37b295a Temporarily disable a test that fails sometimes 
This test is failing often due to an "Unable to autoload constant"
error, that will be fixed after switching to zeitwerk.

Just like it happened in the the "Polls can be listed" test, the reason
seems to be accessing a page containing several ActiveStorage
attachments. However, since this test only makes sense when two or more
images are displayed on the page, we can't change the test so create
just one image.

So, for now, we're commenting the test, and we'll uncomment it again
when we enable zeitwerk in version 2.2.0.
 2024-03-18 15:09:17 +01:00
Javi Martín
bbac39e976 Merge pull request #5426 from consuldemocracy/fix_comment_votes_html 
Fix invalid HTML in comment votes
 2024-03-18 15:02:25 +01:00
Javi Martín
d921eee30d Update Code Climate Rubocop version 
Code Climate was failing to analyze our repo because their rubocop 1.31
doesn't support rubocop-capybara.

Since we're using rubocop 1.56.4 in our code, we're going to use
version 1.56.3 for Code Climate which, at the time of writing, is the
latest available version in Code Climate.
 2024-03-18 14:54:46 +01:00
Javi Martín
a670b77e75 Merge pull request #5399 from consuldemocracy/dependabot/bundler/view_component-3.11.0 
Bump view_component from 3.6.0 to 3.11.0
 2024-03-18 14:49:00 +01:00
Javi Martín
8006227bb4 Merge pull request #5403 from consuldemocracy/missing_spanish_translations 
Add missing Spanish translations
 2024-03-08 15:51:21 +01:00
Javi Martín
3d63238ef6 Add missing Spanish translations 
These texts were added in English in commit 7070b0915, but we forgot to
add the texts in Spanish as well.
 2024-03-08 15:15:34 +01:00
CoslaJohn
8b3ec8fc79 Applied patch to tidy whitespace and add tests 2024-03-07 12:08:17 +00:00
Javi Martín
a101608ebe Fix invalid HTML in comment votes 
We forgot to change the `span` tag when we replaced links with buttons
in commit ba0d21b46.
 2024-03-05 00:41:53 +01:00
Javi Martín
deb8b374e7 Simplify creating a proposal poll in a test 
This way we avoid variables starting with underscores, which we don't
use almost anywhere else.
 2024-03-02 23:43:44 +01:00
Javi Martín
c480cdd918 Don't create records after a visit in polls tests 
Creating records after starting the browser with the `visit` method
sometimes results in database corruption and failing tests on our CI.

Splitting some tests or merging them together solves the issue.
 2024-03-02 23:43:26 +01:00
Javi Martín
2af1fc72f3 Prevent Unable to autoload constant error in tests 
When running these tests, under certain conditions, we get a warning
followed by an error:

```
activesupport-6.1.7.7/lib/active_support/dependencies.rb:502:
warning: already initialized constant ActiveStorage::Representations

activesupport-6.1.7.7/lib/active_support/dependencies.rb:502:
warning: previous definition of Representations was here

Failure/Error: raise LoadError, "Unable to autoload constant
'#{qualified_name}', expected #{file_path} to define it"

LoadError: Unable to autoload constant
ActiveStorage::Representations::RedirectController, expected
activestorage-6.1.7.7/app/controllers/active_storage/representations/redirect_controller.rb
to define it
```

The error seems to take place when we request a page in a test that
loads two (or more) ActiveStorage images if ActiveStorage hasn't loaded
yet, although it's a flaky error and so the test doesn't always behave
like this.

We've tested that switching to zeitwerk solves the issue but, since we
aren't switching to zeitwerk in version 2.1.1 and we'd like this version
to run all tests correctly, for now we're changing the tests so they
don't load two records with images.

On of these tests ("Polls Index Polls can be listed") fails on my
machine when run individually. I haven't been able to consistently
reproduce the other ones.
 2024-03-02 22:06:25 +01:00
Javi Martín
1d955b7a20 Simplify using helper methods in components 
The `use_helpers` method was added in ViewComponent 3.8.0, and it's
included by default in all components since version 3.11.0.

Note we sometimes delegated the `can?` method to the controller instead
of the helpers, for no particularly reason. We're unifying that code as
well.
 2024-03-02 17:34:25 +01:00
dependabot[bot]
52ec5094f0 Bump view_component from 3.6.0 to 3.11.0 
Bumps [view_component](https://github.com/viewcomponent/view_component) from 3.6.0 to 3.11.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases)
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md)
- [Commits](https://github.com/viewcomponent/view_component/compare/v3.6.0...v3.11.0)

---
updated-dependencies:
- dependency-name: view_component
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-02 17:34:25 +01:00
Javi Martín
8ac1acc5ea Merge pull request #5374 from consuldemocracy/dependabot/bundler/bullet-7.1.6 
Bump bullet from 7.0.7 to 7.1.6
 2024-03-02 17:31:59 +01:00
dependabot[bot]
331784e926 Bump bullet from 7.0.7 to 7.1.6 
Bumps [bullet](https://github.com/flyerhzm/bullet) from 7.0.7 to 7.1.6.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/flyerhzm/bullet/compare/7.0.7...7.1.6)

---
updated-dependencies:
- dependency-name: bullet
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-02 03:00:10 +00:00
Javi Martín
a6f3952c3b Merge pull request #5361 from consuldemocracy/dependabot/bundler/pdf-reader-2.12.0 
Bump pdf-reader from 2.11.0 to 2.12.0
 2024-03-02 03:43:06 +01:00
dependabot[bot]
ac9472cc0b Bump pdf-reader from 2.11.0 to 2.12.0 
Bumps [pdf-reader](https://github.com/yob/pdf-reader) from 2.11.0 to 2.12.0.
- [Changelog](https://github.com/yob/pdf-reader/blob/main/CHANGELOG)
- [Commits](https://github.com/yob/pdf-reader/compare/v2.11.0...v2.12.0)

---
updated-dependencies:
- dependency-name: pdf-reader
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-02 03:19:02 +01:00
Javi Martín
8ec1edca30 Merge pull request #5373 from consuldemocracy/dependabot/bundler/faker-3.2.3 
Bump faker from 3.2.1 to 3.2.3
 2024-03-02 03:15:19 +01:00
dependabot[bot]
518eb333b4 Bump faker from 3.2.1 to 3.2.3 
Bumps [faker](https://github.com/faker-ruby/faker) from 3.2.1 to 3.2.3.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v3.2.1...v3.2.3)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-02 02:00:07 +00:00
Javi Martín
a30917b746 Merge pull request #5356 from consuldemocracy/dependabot/bundler/factory_bot_rails-6.4.3 
Bump factory_bot_rails from 6.2.0 to 6.4.3
 2024-03-02 02:58:19 +01:00
dependabot[bot]
56311eeefb Bump factory_bot_rails from 6.2.0 to 6.4.3 
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.2.0 to 6.4.3.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md)
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v6.2.0...v6.4.3)

---
updated-dependencies:
- dependency-name: factory_bot_rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-02 01:21:14 +00:00
Javi Martín
70edfbe624 Merge pull request #5290 from consuldemocracy/dependabot/bundler/mdl-0.13.0 
Bump mdl from 0.12.0 to 0.13.0
 2024-03-02 02:15:00 +01:00
dependabot[bot]
99b9167e72 Bump mdl from 0.12.0 to 0.13.0 
Bumps [mdl](https://github.com/mivok/markdownlint) from 0.12.0 to 0.13.0.
- [Changelog](https://github.com/markdownlint/markdownlint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/mivok/markdownlint/compare/v0.12.0...v0.13.0)

---
updated-dependencies:
- dependency-name: mdl
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-02 00:51:07 +00:00
Javi Martín
5624e0fead Merge pull request #5420 from consuldemocracy/update_upload_artifact_action_to_version_4 
Update upload artifact action to version 4
 2024-03-02 01:28:43 +01:00
Javi Martín
7ae8df8af7 Merge pull request #5362 from consuldemocracy/dependabot/bundler/rubocop-rails-2.23.1 
Bump rubocop-rails from 2.21.2 to 2.23.1
 2024-03-02 01:18:06 +01:00
Javi Martín
acfaada82b Update upload artifact action to version 4 
We were getting a warning with version 3:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/upload-artifact@v3. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
 2024-03-02 00:51:22 +01:00
dependabot[bot]
bbb4c84ddb Bump rubocop-rails from 2.21.2 to 2.23.1 
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.21.2 to 2.23.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.21.2...v2.23.1)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-01 23:46:40 +00:00
Javi Martín
1fe03937f9 Merge pull request #5419 from consuldemocracy/update_setup_node_action_to_version_4 
Update setup-node action to version 4
 2024-03-02 00:44:33 +01:00
Javi Martín
23e54892d5 Update setup-node action to version 4 
We were getting a warning with version 3:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/setup-node@v3. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
 2024-03-02 00:29:43 +01:00
Javi Martín
fbe46c95df Merge pull request #5415 from consuldemocracy/update_checkout_action_to_version_4 
Update checkout action to version 4
 2024-03-02 00:13:04 +01:00
Javi Martín
3fa16bc882 Update checkout action to version 4 
We were getting some warnings with version 3:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/checkout@v3. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
 2024-03-01 23:46:30 +01:00
Javi Martín
dc5267320b Merge pull request #5411 from consuldemocracy/update_upload_artifact_action 
Update upload artifact action to version 3
 2024-03-01 23:44:55 +01:00
Javi Martín
e07650e09b Update upload artifact action to version 3 
We were getting a warning with version 2:

The following actions uses node12 which is deprecated and will be forced
to run on node16: actions/upload-artifact@v2. For more info:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
 2024-03-01 23:11:39 +01:00
Javi Martín
e9af16f266 Merge pull request #5407 from consuldemocracy/update_checkout_action 
Update checkout action to version 3
 2024-03-01 23:08:21 +01:00
Javi Martín
b60d2f45b8 Update checkout action to version 3 
We were getting a warning with version 2:

The following actions uses node12 which is deprecated and will be forced
to run on node16: actions/checkout@v2. For more info:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
 2024-03-01 21:58:42 +01:00
Javi Martín
5658b6f502 Merge pull request #5378 from consuldemocracy/dependabot/bundler/capybara-3.40.0 
Bump capybara from 3.39.2 to 3.40.0
 2024-03-01 21:55:46 +01:00
dependabot[bot]
139da18b19 Bump capybara from 3.39.2 to 3.40.0 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.39.2 to 3.40.0.
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.39.2...3.40.0)

---
updated-dependencies:
- dependency-name: capybara
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-01 19:53:06 +00:00
Javi Martín
ed24a16f61 Merge pull request #5405 from consuldemocracy/dependabot/bundler/rubocop-rspec-2.27.0 
Bump rubocop-rspec from 2.24.1 to 2.27.0
 2024-03-01 20:51:06 +01:00
dependabot[bot]
86b72ad7be Bump rubocop-rspec from 2.24.1 to 2.27.0 
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.24.1 to 2.27.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.24.1...v2.27.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-01 19:22:10 +00:00
Javi Martín
8c0c952361 Merge pull request #5385 from consuldemocracy/dependabot/bundler/rubocop-factory_bot-2.25.1 
Bump rubocop-factory_bot from 2.24.0 to 2.25.1
 2024-03-01 20:20:01 +01:00
dependabot[bot]
7fc40ef3d3 Bump rubocop-factory_bot from 2.24.0 to 2.25.1 
Bumps [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot) from 2.24.0 to 2.25.1.
- [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases)
- [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-factory_bot/compare/v2.24.0...v2.25.1)

---
updated-dependencies:
- dependency-name: rubocop-factory_bot
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-01 18:09:55 +00:00
Javi Martín
4c4699cb31 Merge pull request #5383 from consuldemocracy/dependabot/bundler/rubocop-capybara-2.20.0 
Bump rubocop-capybara from 2.19.0 to 2.20.0
 2024-03-01 19:07:59 +01:00
dependabot[bot]
5772e1b14e Bump rubocop-capybara from 2.19.0 to 2.20.0 
Note that this version changed the default enforced styles for
ClickLinkOrButtonStyle and NegationMatcher, so we're now specifying
them.

Bumps [rubocop-capybara](https://github.com/rubocop/rubocop-capybara) from 2.19.0 to 2.20.0.
- [Release notes](https://github.com/rubocop/rubocop-capybara/releases)
- [Changelog](https://github.com/rubocop/rubocop-capybara/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-capybara/compare/v2.19.0...v2.20.0)

---
updated-dependencies:
- dependency-name: rubocop-capybara
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-01 18:38:13 +01:00
Javi Martín
65ad1824fa Merge pull request #5401 from consuldemocracy/dependabot/bundler/rails-6.1.7.7 
Bump rails from 6.1.7.6 to 6.1.7.7
 2024-02-28 17:17:20 +01:00
Javi Martín
9ecab3bac6 Bump Rails to version 6.1.7.7 2024-02-28 16:04:38 +01:00
Javi Martín
07e4b8f14c Merge pull request #5365 from consuldemocracy/dependabot/bundler/puma-5.6.8 
Bump puma from 5.6.7 to 5.6.8
 2024-02-23 19:54:29 +01:00