Javi Martín
d0d681a44b
Add and apply EmptyLineAfterGuardClause rule
...
We were inconsistent on this one. I consider it particularly useful when
a method starts with a `return` statement.
In other cases, we probably shouldn't have a guard rule in the middle of
a method in any case, but that's a different refactoring.
2019-10-24 17:56:03 +02:00
Javi Martín
db97f9d08c
Add and apply rubocop rules for empty lines
...
We were very inconsistent regarding these rules.
Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.
The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.
[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Javi Martín
431074c99f
Add save! method to ActiveModel models
...
This way we make it clear we expect records to be valid when we save
them, just like we do with ActiveRecord models.
2019-10-23 14:32:42 +02:00
Javi Martín
9fe8c47528
Apply Rails/SafeNavigation rubocop rule
2019-09-10 21:43:39 +02:00
Julian Herrero
3ba961a2d7
Use double quotes in models
2019-03-14 17:25:43 +01:00
kikito
f0b8cfd4a2
Time.now -> Time.current
2016-11-23 19:19:19 +01:00
Juanjo Bazán
cf4f9945e8
checks letter verification code as integers
2015-10-27 19:15:01 +01:00
Juanjo Bazán
bd4168ef75
changes generation of letter verification code
...
to keep generating six digit numbers but avoid starting with zero because can led to errors when sent to users.
2015-10-27 13:32:38 +01:00
kikito
f08cf591b6
fixes an issue where users which requested a letter did not get the verification code set up
2015-10-21 12:08:56 +02:00
kikito
0d0806c9ae
improvements in the letter verification error messages
2015-10-20 16:19:17 +02:00
kikito
20aee99bbf
remove letter_sent verification
2015-10-20 13:16:40 +02:00
rgarcia
8904748ae2
fixes specs
2015-10-19 23:23:09 +02:00
rgarcia
5fe1bb3eee
verifies the letter's code
2015-10-19 22:58:44 +02:00
rgarcia
0d01f431fb
simplifies verification form
2015-10-19 20:33:10 +02:00
rgarcia
fbb5db8062
removes unnecessary address from users
2015-09-26 13:45:37 +02:00
rgarcia
b7c1b4acee
renames verify? methods [ #395 ]
2015-09-10 20:08:11 +02:00
rgarcia
8186f5a240
refactors method names for validations [ #395 ]
2015-09-10 20:06:45 +02:00
rgarcia
fa2b6e78ef
refactors address validation [ #395 ]
2015-09-10 14:28:16 +02:00
rgarcia
cd74744e06
adds validation error for letter verification code [ #395 ]
2015-09-10 14:27:02 +02:00
rgarcia
b779e7903c
refactors letter and sms generation codes [ #332 ]
2015-09-10 11:45:19 +02:00
rgarcia
745dbc3f51
makes the letter code 6 digits [ #332 ]
2015-09-10 11:44:09 +02:00
rgarcia
16dd609ad0
adds verification tries to letter code [ #332 ]
2015-09-10 11:43:25 +02:00
rgarcia
99d779bcec
adds letter code verification
2015-09-02 21:57:03 +02:00
Juanjo Bazán
50dcbcdf9b
moves Letter to Verification namespace
2015-08-29 12:07:43 +02:00
