Javi Martín
db97f9d08c
Add and apply rubocop rules for empty lines
...
We were very inconsistent regarding these rules.
Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.
The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.
[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Javi Martín
431074c99f
Add save! method to ActiveModel models
...
This way we make it clear we expect records to be valid when we save
them, just like we do with ActiveRecord models.
2019-10-23 14:32:42 +02:00
Javi Martín
ffc50246c2
Apply explict RSpec/DescribedClass rubocop rule
...
We settled on using this style in commit 4cbe81a1
2019-09-23 16:51:00 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
c4aa2d7093
Enable RSpec/MessageExpectation cop & fix issues
...
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
2018-01-07 16:36:18 +01:00
Bertocq
2253155a51
Enables RSpec/EmptyLineAfterSubject & fixes all issues
...
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterSubject
2018-01-07 00:50:50 +01:00
Bertocq
e6dd33bd66
Fix all Layout/SpaceAfterComma issues and remove from rubocop_todo list
2017-06-26 17:57:53 +02:00
kikito
050971c459
modifies email controllers: management email makes users level two verified, and sets their document number permanently. Fixes failing test
2015-10-13 17:20:39 +02:00
kikito
615527b532
adds specs for verification/management/email.rb
2015-10-06 18:02:25 +02:00
