Commit Graph

15 Commits

Author SHA1 Message Date
Javi Martín
11b962da8f Add and apply Style/MinMaxComparison rubocop rule
This rule was added in rubocop 1.42.0.
2023-09-07 13:09:11 +02:00
Javi Martín
eafb4018bf Apply Style/CollectionMethods rubocop rule
We were already using `map` and `reduce` almost everywhere.
2019-10-26 13:03:49 +02:00
Javi Martín
d0d681a44b Add and apply EmptyLineAfterGuardClause rule
We were inconsistent on this one. I consider it particularly useful when
a method starts with a `return` statement.

In other cases, we probably shouldn't have a guard rule in the middle of
a method in any case, but that's a different refactoring.
2019-10-24 17:56:03 +02:00
Javi Martín
db97f9d08c Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Javi Martín
47b2c42a1d Apply IndentationConsistency rubocop rule 2019-09-10 20:02:15 +02:00
Bertocq
3adfbcb830 Fix Shift date ranges when poll is on recounting phase 2017-10-23 20:17:42 +02:00
Bertocq
d15f150e98 Trim officer shifts by booth as well 2017-10-18 20:49:30 +02:00
Bertocq
64db7e1dec Merge branch 'master' into fix/shift_date_range_expired 2017-10-16 19:43:00 +02:00
María Checa
a6d533a767 Helper improvements 2017-10-16 13:47:10 +02:00
María Checa
45f73aa1ba Excluded officer shift dates from each task date range 2017-10-16 12:22:54 +02:00
Bertocq
16f499d5fd Force shift dates to start on current date at minimun 2017-10-13 17:19:51 +02:00
Bertocq
540e12a3ac Add RECOUNT_DURATION Poll constant for recount period duration 2017-10-13 16:47:47 +02:00
Bertocq
9d7be9b57c Sort Shift recount and scrutiny dates 2017-10-02 13:46:02 +02:00
Bertocq
f40a0d09ed Add Shift vote and recount date ranges, filter selected one on controller 2017-09-27 18:08:03 +02:00
rgarcia
456429f08b adds shifts 2017-08-04 21:27:30 +02:00