consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,442 Commits 1 Branch 0 Tags
06dcbd699c46b77563f4d35d3c68a9387674b108
Commit Graph

15 Commits

Author SHA1 Message Date
Senén Rodero Rodríguez
06dcbd699c Extract block to configure remote census in tests 
Co-Authored-By: Javi Martín <javim@elretirao.net>
 2020-11-02 11:42:39 +01:00
Javi Martín
db97f9d08c Add and apply rubocop rules for empty lines 
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
 2019-10-24 17:11:47 +02:00
Javi Martín
4301937e85 Check arrays are empty instead of size 0 
In ruby we check for `array.empty?` instead of `array.size == 0`, so
it's natural to write the tests in the same way.
 2019-09-24 21:32:28 +02:00
Javi Martín
ffc50246c2 Apply explict RSpec/DescribedClass rubocop rule 
We settled on using this style in commit 4cbe81a1, but didn't add the
rule enforcing this style and we didn't apply it to existing code.
 2019-09-23 16:51:00 +02:00
Javi Martín
da121ebc53 Remove redundant setting resets in after blocks 
Settings are stored in the database, and so any changes to the settings
done during the tests are automatically rolled back between one test and
the next one.

There were also a few places where we weren't using an `after` block but
changing the setting at the end of the test.
 2019-09-23 13:47:45 +02:00
taitus
6e62ea81a9 Add new model presence validates 
- Only validate :date_of_birth and :postal_code presence when the
  application has configured Remote Census and their alias fields
  has values.
 2019-07-29 13:10:09 +02:00
taitus
bc36c5a987 Allow to Management::Document works with CustomCensusAPI 
- Allow receive new fields :date_of_birth and :postal_code
- Send new fields to CensusCaller call method to allow use
  on RemoteCensusAPI
 2019-07-29 13:10:09 +02:00
Julian Herrero
31ac8b7f55 Change single quotes to double quotes 2019-02-15 11:40:39 +01:00
Bertocq
830bb37189 Enable RSpec/VerifiedDoubles cop, fix issues & stash one 
Can't figureout solution for offense at spec/models/verification/management/email_spec.rb
 so its stashed at .rubocop_todo.yml

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubles
 2018-01-07 18:47:19 +01:00
Bertocq
265d4d0967 Enables RSpec/DescribedClass cop & fixes all issues 
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
 2018-01-07 00:38:19 +01:00
Bertocq
69f4e1c683 Fix all rubocop Metrics/LineLength issues (140+) 2017-07-10 13:22:49 +02:00
Juanjo Bazán
5a0d28f9f0 updates verification spec 2017-01-09 16:05:44 +01:00
Juanjo Bazán
e2118f701b removes hardcoded age, favours setting 2017-01-09 16:05:27 +01:00
kikito
d7f9862290 fixes failing specs 2016-04-13 12:06:50 +02:00
Juanjo Bazán
07117f4a49 includes all date in document age verification 2015-10-19 12:18:42 +02:00