Javi Martín
033f3c33e3
Add SpaceAroundEqualsInParameterDefault rule
...
We were using it in most places, but not everywhere.
2019-10-24 17:56:03 +02:00
Senén Rodero Rodríguez
64bfab9c9c
Extract spec methods to commons module to avoid code duplication
...
Because "translatable" and "new_translatable" shared examples needs same methods to manipulate translations.
2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
78c2f54c5d
Fix proposal specs
...
After adding proposal translatable fields to forms, they will be generated with nested translations names and ids so we can no longer
use standard id locator.
Using input label text to fill in fields works with both types of forms.
2019-06-27 09:19:36 +02:00
decabeza
f40787561d
Remove all references to question and external_url fields
2019-04-30 16:42:07 +02:00
rgarcia
74706027cb
fixes specs
2019-03-28 15:47:52 +01:00
rgarcia
b4499321d3
stores officer booth on sign in
2019-03-28 15:47:52 +01:00
rgarcia
cc4eed3500
fixes specs
2019-03-28 15:47:52 +01:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Angel Perez
1e1cb660e2
Add missing CommonActions#fill_in_signup_form method
...
This method allows to fill in CONSUL's signup form without interacting
with other UI elements, useful when using testing locales other than English
Backported from Decide Madrid
2018-09-10 16:05:55 -04:00
Adan Amarillas
ee877888b3
Split spec common actions support helper
2018-06-04 08:55:53 -07:00
iagirre
d84895b800
Add test suite for the feature
...
The tests that will check the featute
is working well added. There are four test:
1. Checks that the emails are been send to
the user. The test looks for the link in there
and takes the token. Visits the page and
changes the password.
2 and 3. Both change the password by hand. One
uses a password written by the manager, whilst
the other uses the 'Generate random password'
option. Both tests check that the user can
sign in with the new passwords.
4. Checks that the password can be printed
when it is saved.
2018-04-02 09:43:17 +02:00
Angel Perez
38af45d450
Replace deprecated .trigger('click') API with .click
2018-03-27 14:47:49 -04:00
rgarcia
09c44ee583
Extend notifications to be marked as read and unread
2018-03-23 11:47:06 +01:00
iagirre
e21588ec16
The function comment_on has been modified to change the functionality. Now, a comment is generated and a email notification send manually, so that JS has been avoided, that was the original problem.
2018-03-02 13:35:50 +01:00
María Checa
017c242085
Merge pull request #2462 from consul/admin-newsletter-emails
...
Admin newsletter emails
2018-02-20 16:17:37 +01:00
Bertocq
4e34a1cf41
Fix common actions file rubocop issues
2018-02-15 23:17:10 +01:00
María Checa
e8c797766a
Added newsletter specs
2018-02-14 16:06:33 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
decabeza
f95d5d4639
improves generic error message
2017-12-22 12:32:34 +01:00
Bertocq
cf8cfe363b
Fix gsub+downcase usage with parameterize
2017-12-16 17:59:16 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
Angel Perez
2bdc2c27d7
Add email specs for Poll
2017-11-17 13:14:03 -04:00
Angel Perez
4c110e8100
Add email specs for Topic
2017-11-17 13:14:03 -04:00
Angel Perez
3605a43947
Add email specs for Budget::Investment
2017-11-17 13:14:03 -04:00
Bertocq
cd66ba5d54
Rubocop autocorrections
2017-11-13 02:22:00 +01:00
María Checa
bb06af3877
Improved results tests
2017-10-20 16:49:25 +02:00
María Checa
8be8bb07f9
Added first poll results tests
2017-10-19 12:17:49 +02:00
Bertocq
ce0a7f6fad
Rubocop autocorrections
2017-10-17 22:00:00 +02:00
rgarcia
6b7d38c27a
adds spec for user voting in poll and then verifying account
2017-10-17 15:00:34 +02:00
María Checa
5b7a90221a
Fixed tests
2017-10-04 11:18:09 +02:00
Bertocq
825671ad9b
Fix polls answer this question show text
2017-10-03 18:53:44 +02:00
rgarcia
085991c624
allows voting only in one origin: booth or web
2017-10-02 16:22:31 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Bertocq
d7b8777395
Fix all Layout/SpaceAroundEqualsInParameterDefault rubocop issues from rubocop_todo list
2017-06-26 18:03:40 +02:00
Juanjo Bazán
c4ba6a7e94
updates specs
2017-06-12 19:48:57 +02:00
rgarcia
5c676498e2
fixes specs
2017-02-01 11:37:11 +01:00
rgarcia
6c34599e1e
adds officer residence check and user voting
2017-01-29 00:36:20 +01:00
Juanjo Bazán
113f9b32d7
Merge branch 'master' into polls
2017-01-19 16:51:19 +01:00
Juanjo Bazán
5ec12e4b5b
Merge branch 'master' into redux-polling
2016-12-27 18:22:06 +01:00
kikito
7089d965d5
Removes unused common actions
2016-12-25 12:57:57 +01:00
kikito
4589ba5f0b
Fixes incorrect implementation of add_to_ballot common action
2016-12-23 18:34:42 +01:00
kikito
2e8650c324
merge with master
2016-12-12 16:09:05 +01:00
Alberto Garcia Cabeza
87e7e7e4ea
fixes specs
2016-12-07 18:16:09 +01:00
kikito
2a2179d0f3
Merge branch 'master' into budget
2016-11-28 11:41:49 +01:00
kikito
f0b8cfd4a2
Time.now -> Time.current
2016-11-23 19:19:19 +01:00
rgarcia
e12f183775
fixes typo
2016-11-19 14:03:10 +01:00
rgarcia
bb3c4c6399
adds consistency to ruby code style
...
Keep a blank line before and after private
Keep a blank line before and after protected
Remove extra empty line at class body end
Remove extra blank line
Add final newline
Use 2 (not 3) spaces for indentation
Use 2 (not 4) spaces for indentation
Remove space before comma
Add space after comma
Remove trailing whitespaces
Remove unnecessary spacing
Use snake_case for variable names
Do not use then for multi-line if
Remove unused block argument - i
Use the new Ruby 1.9 hash syntax
Remove unused assignment to variable
Indent when as deep as case
Align attributes
Align end with def
2016-11-15 11:18:43 +01:00
Alberto Garcia Cabeza
6fd5e6a67a
unifies styles for participation not allowed
2016-10-31 16:50:13 +01:00
Alberto Garcia Cabeza
910b24936d
Merge branch 'master' into voting-proposals
...
Conflicts:
app/models/proposal.rb
app/views/proposals/_proposal.html.erb
app/views/proposals/index.html.erb
app/views/proposals/show.html.erb
spec/support/common_actions.rb
2016-09-15 13:58:53 +02:00
Juanjo Bazán
acae610995
adds model specs for archived proposal
2016-09-12 18:15:18 +02:00
