Apply explict RSpec/DescribedClass rubocop rule
We settled on using this style in commit 4cbe81a1, but didn't add the
rule enforcing this style and we didn't apply it to existing code.
This commit is contained in:
@@ -131,8 +131,8 @@ describe Comment do
|
||||
create(:comment, administrator_id: create(:administrator).id)
|
||||
create(:comment, moderator_id: create(:moderator).id)
|
||||
|
||||
expect(described_class.not_as_admin_or_moderator.size).to eq(1)
|
||||
expect(described_class.not_as_admin_or_moderator.first).to eq(comment1)
|
||||
expect(Comment.not_as_admin_or_moderator.size).to eq(1)
|
||||
expect(Comment.not_as_admin_or_moderator.first).to eq(comment1)
|
||||
end
|
||||
end
|
||||
|
||||
@@ -140,60 +140,60 @@ describe Comment do
|
||||
it "returns comments" do
|
||||
comment = create(:comment)
|
||||
|
||||
expect(described_class.public_for_api).to include(comment)
|
||||
expect(Comment.public_for_api).to include(comment)
|
||||
end
|
||||
|
||||
it "does not return hidden comments" do
|
||||
hidden_comment = create(:comment, :hidden)
|
||||
|
||||
expect(described_class.public_for_api).not_to include(hidden_comment)
|
||||
expect(Comment.public_for_api).not_to include(hidden_comment)
|
||||
end
|
||||
|
||||
it "returns comments on debates" do
|
||||
debate = create(:debate)
|
||||
comment = create(:comment, commentable: debate)
|
||||
|
||||
expect(described_class.public_for_api).to include(comment)
|
||||
expect(Comment.public_for_api).to include(comment)
|
||||
end
|
||||
|
||||
it "does not return comments on hidden debates" do
|
||||
hidden_debate = create(:debate, :hidden)
|
||||
comment = create(:comment, commentable: hidden_debate)
|
||||
|
||||
expect(described_class.public_for_api).not_to include(comment)
|
||||
expect(Comment.public_for_api).not_to include(comment)
|
||||
end
|
||||
|
||||
it "returns comments on proposals" do
|
||||
proposal = create(:proposal)
|
||||
comment = create(:comment, commentable: proposal)
|
||||
|
||||
expect(described_class.public_for_api).to include(comment)
|
||||
expect(Comment.public_for_api).to include(comment)
|
||||
end
|
||||
|
||||
it "does not return comments on hidden proposals" do
|
||||
hidden_proposal = create(:proposal, :hidden)
|
||||
comment = create(:comment, commentable: hidden_proposal)
|
||||
|
||||
expect(described_class.public_for_api).not_to include(comment)
|
||||
expect(Comment.public_for_api).not_to include(comment)
|
||||
end
|
||||
|
||||
it "does not return comments on elements which are not debates or proposals" do
|
||||
budget_investment = create(:budget_investment)
|
||||
comment = create(:comment, commentable: budget_investment)
|
||||
|
||||
expect(described_class.public_for_api).not_to include(comment)
|
||||
expect(Comment.public_for_api).not_to include(comment)
|
||||
end
|
||||
|
||||
it "does not return comments with no commentable" do
|
||||
comment = build(:comment, commentable: nil).save!(validate: false)
|
||||
|
||||
expect(described_class.public_for_api).not_to include(comment)
|
||||
expect(Comment.public_for_api).not_to include(comment)
|
||||
end
|
||||
|
||||
it "does not return internal valuation comments" do
|
||||
valuation_comment = create(:comment, :valuation)
|
||||
|
||||
expect(described_class.public_for_api).not_to include(valuation_comment)
|
||||
expect(Comment.public_for_api).not_to include(valuation_comment)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user