Add and apply Style/ArgumentsForwarding rule

We were using generic names like `args` and `options` which don't really
add anything to `*` or `**` because Ruby required us to.

That's no longer the case in Ruby 3.2, so we can simplify the code a
bit.

.rubocop.yml

@@ -647,6 +647,9 @@ Style/AccessorGrouping:
 Style/AndOr:
   Enabled: true
 
+Style/ArgumentsForwarding:
+  Enabled: true
+
 Style/ArrayCoercion:
   Enabled: true
 

app/components/admin/budgets/actions_component.rb

@@ -7,13 +7,8 @@ class Admin::Budgets::ActionsComponent < ApplicationComponent
 
   private
 
-    def action(action_name, **options)
+    def action(action_name, **)
-      render Admin::ActionComponent.new(
+      render Admin::ActionComponent.new(action_name, budget, "aria-describedby": true, **)
-        action_name,
-        budget,
-        "aria-describedby": true,
-        **options
-      )
     end
 
     def actions

app/components/admin/budgets/links_component.rb

@@ -8,8 +8,8 @@ class Admin::Budgets::LinksComponent < ApplicationComponent
 
   private
 
-    def action(action_name, **options)
+    def action(action_name, **)
-      render Admin::ActionComponent.new(action_name, budget, **options)
+      render Admin::ActionComponent.new(action_name, budget, **)
     end
 
     def results_text

app/components/admin/table_actions_component.rb

@@ -6,8 +6,8 @@ class Admin::TableActionsComponent < ApplicationComponent
     @options = options
   end
 
-  def action(action_name, **args)
+  def action(action_name, **)
-    render Admin::ActionComponent.new(action_name, record, "aria-label": true, **args)
+    render Admin::ActionComponent.new(action_name, record, "aria-label": true, **)
   end
 
   private

app/controllers/concerns/feature_flags.rb

@@ -2,8 +2,8 @@ module FeatureFlags
   extend ActiveSupport::Concern
 
   class_methods do
-    def feature_flag(name, *options)
+    def feature_flag(name, *)
-      before_action(*options) do
+      before_action(*) do
         check_feature_flag(name)
       end
     end

app/controllers/concerns/has_filters.rb

@@ -7,8 +7,8 @@ module HasFilters
   end
 
   class_methods do
-    def has_filters(valid_filters, *args)
+    def has_filters(valid_filters, *)
-      before_action(*args) do
+      before_action(*) do
         @valid_filters = valid_filters.respond_to?(:call) ? valid_filters.call(self) : valid_filters
         @current_filter = @valid_filters.include?(params[:filter]) ? params[:filter] : @valid_filters.first
       end

app/controllers/concerns/has_orders.rb

@@ -7,8 +7,8 @@ module HasOrders
   end
 
   class_methods do
-    def has_orders(valid_orders, *args)
+    def has_orders(valid_orders, *)
-      before_action(*args) do |c|
+      before_action(*) do |c|
         @valid_orders = valid_orders.respond_to?(:call) ? valid_orders.call(c) : valid_orders.dup
         @valid_orders.delete("relevance") if params[:search].blank?
         @current_order = @valid_orders.include?(params[:order]) ? params[:order] : @valid_orders.first

app/controllers/concerns/remotely_translatable.rb

@@ -1,10 +1,10 @@
 module RemotelyTranslatable
   private
 
-    def detect_remote_translations(*args)
+    def detect_remote_translations(*)
       return [] unless Setting["feature.remote_translations"].present? && api_key_has_been_set_in_secrets?
 
-      RemoteTranslation.for(*args)
+      RemoteTranslation.for(*)
     end
 
     def api_key_has_been_set_in_secrets?

app/helpers/application_helper.rb

@@ -10,8 +10,8 @@ module ApplicationHelper
     %i[ar fa he].include?(locale)
   end
 
-  def markdown(text, **render_options)
+  def markdown(text, **)
-    MarkdownConverter.new(text, **render_options).render
+    MarkdownConverter.new(text, **).render
   end
 
   def wysiwyg(text)

app/helpers/link_list_helper.rb

@@ -1,5 +1,5 @@
 module LinkListHelper
-  def link_list(*links, **options)
+  def link_list(*, **)
-    render Shared::LinkListComponent.new(*links, **options)
+    render Shared::LinkListComponent.new(*, **)
   end
 end

app/models/remote_translation.rb

@@ -12,8 +12,8 @@ class RemoteTranslation < ApplicationRecord
     RemoteTranslations::Caller.new(self).delay.call
   end
 
-  def self.for(*args)
+  def self.for(*)
-    resources_groups(*args).flatten.select { |resource| translation_empty?(resource) }.map do |resource|
+    resources_groups(*).flatten.select { |resource| translation_empty?(resource) }.map do |resource|
       new(remote_translatable: resource, locale: I18n.locale)
     end
   end

app/models/user.rb

@@ -409,8 +409,8 @@ class User < ApplicationRecord
     followables.compact.map { |followable| followable.tags.map(&:name) }.flatten.compact.uniq
   end
 
-  def send_devise_notification(notification, *args)
+  def send_devise_notification(notification, *)
-    devise_mailer.send(notification, self, *args).deliver_later
+    devise_mailer.send(notification, self, *).deliver_later
   end
 
   def add_subscriptions_token