From f8fb32db76ec414f5f75d6ae7085f31b7a71fa58 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Sun, 7 Jan 2018 17:51:19 +0100 Subject: [PATCH] Enable RSpec/ScatteredLet cop & fix issue Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet --- .rubocop.yml | 3 +++ spec/models/abilities/valuator_spec.rb | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 21602a67a..a155bad11 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -164,4 +164,7 @@ RSpec/RepeatedExample: Enabled: true RSpec/ReturnFromStub: + Enabled: true + +RSpec/ScatteredLet: Enabled: true \ No newline at end of file diff --git a/spec/models/abilities/valuator_spec.rb b/spec/models/abilities/valuator_spec.rb index 5c19e4e12..1a6b7927d 100644 --- a/spec/models/abilities/valuator_spec.rb +++ b/spec/models/abilities/valuator_spec.rb @@ -7,12 +7,10 @@ describe Abilities::Valuator do let(:user) { valuator.user } let(:valuator) { create(:valuator) } let(:non_assigned_investment) { create(:budget_investment) } - let(:assigned_investment) { create(:budget_investment, budget: create(:budget, phase: 'valuating')) } - before { assigned_investment.valuators << valuator } - let(:finished_assigned_investment) { create(:budget_investment, budget: create(:budget, phase: 'finished')) } + before { assigned_investment.valuators << valuator } before { finished_assigned_investment.valuators << valuator } it { should be_able_to(:read, SpendingProposal) }