consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent default event on JavaScript-only links

Browse Source 
These links point to "#" and don't do anything without JavaScript
activated, and they were causing the browser to scroll to the top of the
page.
This commit is contained in:
Javi Martín
2019-09-13 17:44:12 +02:00
parent ae2b4b16c6
commit f8c9f09887
3 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/check_all_none.js
View File

@@ -2,13 +2,17 @@
"use strict"; "use strict";
App.CheckAllNone = { App.CheckAllNone = {
initialize: function() { initialize: function() {
$("[data-check-all]").on("click", function() { $("[data-check-all]").on("click", function(e) {
var target_name; var target_name;
e.preventDefault();
e.stopPropagation();
target_name = $(this).data("check-all"); target_name = $(this).data("check-all");
$("[name='" + target_name + "']").prop("checked", true); $("[name='" + target_name + "']").prop("checked", true);
}); });
$("[data-check-none]").on("click", function() { $("[data-check-none]").on("click", function(e) {
var target_name; var target_name;
e.preventDefault();
e.stopPropagation();
target_name = $(this).data("check-none"); target_name = $(this).data("check-none");
$("[name='" + target_name + "']").prop("checked", false); $("[name='" + target_name + "']").prop("checked", false);
}); });

8
app/assets/javascripts/managers.js
View File

@@ -17,10 +17,14 @@
$("#user_password").prop("type", type); $("#user_password").prop("type", type);
}, },
initialize: function() { initialize: function() {
$(".generate-random-value").on("click", function() { $(".generate-random-value").on("click", function(e) {
e.preventDefault();
e.stopPropagation();
$("#user_password").val(App.Managers.generatePassword()); $("#user_password").val(App.Managers.generatePassword());
}); });
$(".show-password").on("click", function() { $(".show-password").on("click", function(e) {
e.preventDefault();
e.stopPropagation();
if ($("#user_password").is("input[type='password']")) { if ($("#user_password").is("input[type='password']")) {
App.Managers.togglePassword("text"); App.Managers.togglePassword("text");
} else { } else {

4
app/assets/javascripts/markdown_editor.js
View File

@@ -28,8 +28,10 @@
editor.find("textarea").on("scroll", function() { editor.find("textarea").on("scroll", function() {
editor.find(".markdown-preview").scrollTop($(this).scrollTop()); editor.find(".markdown-preview").scrollTop($(this).scrollTop());
}); });
editor.find(".fullscreen-toggle").on("click", function() { editor.find(".fullscreen-toggle").on("click", function(e) {
var span; var span;
e.preventDefault();
e.stopPropagation();
editor.toggleClass("fullscreen"); editor.toggleClass("fullscreen");
$(".fullscreen-container").toggleClass("medium-8", "medium-12"); $(".fullscreen-container").toggleClass("medium-8", "medium-12");
span = $(this).find("span"); span = $(this).find("span");