From f72daff71fcb0749b473458cc3278d68b4029591 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sun, 6 Oct 2024 14:22:18 +0200
Subject: [PATCH] Simplify JavaScript to toggle investment selection

We don't need to replace the whole row, since the changes only affect
the button. Therefore, we don't need to depend on an `inserted` event to
decide which columns to render in that row.
---
 app/assets/javascripts/columns_selector.js                 | 3 ---
 app/views/admin/budget_investments/toggle_selection.js.erb | 6 +++---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/app/assets/javascripts/columns_selector.js b/app/assets/javascripts/columns_selector.js
index 888dd2c76..40a562510 100644
--- a/app/assets/javascripts/columns_selector.js
+++ b/app/assets/javascripts/columns_selector.js
@@ -80,9 +80,6 @@
           App.ColumnsSelector.toggleColumn(event);
         }
       });
-      $(".column-selectable").on("inserted", function() {
-        App.ColumnsSelector.initColumns();
-      });
     },
     destroy: function() {
       $("#js-columns-selector-wrapper").children(":not(#column_selector_item_template)").remove();
diff --git a/app/views/admin/budget_investments/toggle_selection.js.erb b/app/views/admin/budget_investments/toggle_selection.js.erb
index 75fc98a36..6a99f9783 100644
--- a/app/views/admin/budget_investments/toggle_selection.js.erb
+++ b/app/views/admin/budget_investments/toggle_selection.js.erb
@@ -1,3 +1,3 @@
-$("#<%= dom_id(@investment) %>").replaceWith(
-  "<%= j render Admin::BudgetInvestments::RowComponent.new(@investment) %>"
-).trigger("inserted");
+$("#<%= dom_id(@investment) %> [data-field='selected']").html(
+  "<%= j render(Admin::BudgetInvestments::ToggleSelectionComponent.new(@investment)) %>"
+);