Merge pull request #1678 from consul/feature/1601#budget_winner_investments_button

Add button to Calculate Budget Winner investments

app/controllers/admin/budgets_controller.rb

@@ -14,10 +14,15 @@ class Admin::BudgetsController < Admin::BaseController
     @budget = Budget.includes(groups: :headings).find(params[:id])
   end
 
-  def new
+  def new; end
-  end
 
-  def edit
+  def edit; end
+
+  def calculate_winners
+    return unless @budget.balloting_process?
+    @budget.headings.each { |heading| Budget::Result.new(@budget, heading).calculate_winners }
+    redirect_to admin_budget_budget_investments_path(budget_id: @budget.id, filter: 'winners'),
+                notice: I18n.t("admin.budgets.winners.calculated")
   end
 
   def update

app/models/abilities/administrator.rb

@@ -44,7 +44,7 @@ module Abilities
 
       can [:read, :update, :valuate, :destroy, :summary], SpendingProposal
 
-      can [:index, :read, :new, :create, :update, :destroy], Budget
+      can [:index, :read, :new, :create, :update, :destroy, :calculate_winners], Budget
       can [:read, :create, :update, :destroy], Budget::Group
       can [:read, :create, :update, :destroy], Budget::Heading
       can [:hide, :update, :toggle_selection], Budget::Investment

app/models/budget.rb

@@ -67,8 +67,12 @@ class Budget < ActiveRecord::Base
     phase == "finished"
   end
 
+  def balloting_process?
+    balloting? || reviewing_ballots?
+  end
+
   def balloting_or_later?
-    balloting? || reviewing_ballots? || finished?
+    balloting_process? || finished?
   end
 
   def on_hold?

app/models/budget/result.rb

@@ -12,11 +12,10 @@ class Budget
       reset_winners
       investments.each do |investment|
         @current_investment = investment
-        if inside_budget?
+        set_winner if inside_budget?
-          set_winner
-        end
       end
     end
+    handle_asynchronously :calculate_winners
 
     def investments
       heading.investments.selected.sort_by_ballots

app/views/admin/budgets/_form.html.erb

@@ -16,5 +16,15 @@
       <%= f.select :currency_symbol, budget_currency_symbol_select_options %>
     </div>
   </div>
+  <div class="margin-top">
     <%= f.submit nil, class: "button success" %>
+    <% if @budget.balloting_process? %>
+      <div class="float-right">
+        <%= link_to t("admin.budgets.winners.calculate"),
+                    calculate_winners_admin_budget_path(@budget),
+                    method: :put,
+                    class: "button hollow" %>
+      </div>
+    <% end %>
+  </div>
 <% end %>

config/locales/admin.en.yml

@@ -101,6 +101,9 @@ en:
         no_heading: This group has no assigned heading.
         table_heading: Heading
         table_amount: Amount
+      winners:
+        calculate: Calculate Winner Investments
+        calculated: Winners being calculated, it may take a minute.
     budget_investments:
       index:
         heading_filter_all: All headings

config/locales/admin.es.yml

@@ -101,6 +101,9 @@ es:
         no_heading: Este grupo no tiene ninguna partida asignada.
         table_heading: Partida
         table_amount: Cantidad
+      winners:
+        calculate: Calcular propuestas ganadoras
+        calculated: Calculando ganadoras, puede tardar un minuto.
     budget_investments:
       index:
         heading_filter_all: Todas las partidas

config/locales/admin.fr.yml

@@ -101,6 +101,9 @@ fr:
         no_heading: Ce groupe n'a pas de rubrique assignée.
         table_heading: Rubrique
         table_amount: Montant
+      winners:
+        calculate: Calculate Winner Investments
+        calculated: Winners being calculated, it may take a minute.
     budget_investments:
       index:
         heading_filter_all: Toutes les rubriques

config/locales/admin.nl.yml

@@ -102,6 +102,9 @@ nl:
         no_heading: This group has no assigned heading.
         table_heading: Heading
         table_amount: Amount
+      winners:
+        calculate: Calculate Winner Investments
+        calculated: Winners being calculated, it may take a minute.
     budget_investments:
       index:
         heading_filter_all: All headings

config/routes.rb

@@ -193,6 +193,10 @@ Rails.application.routes.draw do
     end
 
     resources :budgets do
+      member do
+        put :calculate_winners
+      end
+
       resources :budget_groups do
         resources :budget_headings do
         end

spec/features/admin/budgets_spec.rb

@@ -109,6 +109,33 @@ feature 'Admin budgets' do
 
   end
 
+  context "Calculate Budget's Winner Investments" do
+
+    scenario 'For a Budget in reviewing balloting' do
+      budget = create(:budget, phase: 'reviewing_ballots')
+      group = create(:budget_group, budget: budget)
+      heading = create(:budget_heading, group: group, price: 4)
+      unselected_investment = create(:budget_investment, :unselected, heading: heading, price: 1, ballot_lines_count: 3)
+      winner_investment = create(:budget_investment, :winner, heading: heading, price: 3, ballot_lines_count: 2)
+      selected_investment = create(:budget_investment, :selected, heading: heading, price: 2, ballot_lines_count: 1)
+
+      visit edit_admin_budget_path(budget)
+      click_link 'Calculate Winner Investments'
+      expect(page).to have_content 'Winners being calculated, it may take a minute.'
+      expect(page).to have_content winner_investment.title
+      expect(page).not_to have_content unselected_investment.title
+      expect(page).not_to have_content selected_investment.title
+    end
+
+    scenario 'For a finished Budget' do
+      budget = create(:budget, phase: 'finished')
+
+      visit edit_admin_budget_path(budget)
+      expect(page).not_to have_content 'Calculate Winner Investments'
+    end
+
+  end
+
   context 'Manage groups and headings' do
 
     scenario 'Create group', :js do