Show only published draft versions to users (and also drafts to admins)

spec/features/legislation/draft_versions_spec.rb

@@ -1,18 +1,44 @@
 require 'rails_helper'
 
 feature 'Legislation Draft Versions' do
+  let(:user) { create(:user) }
+  let(:administrator) do
+    create(:administrator, user: user)
+    user
+  end
 
   context "See draft text page" do
     before(:each) do
       @process = create(:legislation_process)
-      @draft_version_1 = create(:legislation_draft_version, process: @process, title: "Version 1", body: "Body of the first version")
-      @draft_version_2 = create(:legislation_draft_version, process: @process, title: "Version 2", body: "Body of the second version")
+      @draft_version_1 = create(:legislation_draft_version, process: @process, title: "Version 1", body: "Body of the first version", status: "published")
+      @draft_version_2 = create(:legislation_draft_version, process: @process, title: "Version 2", body: "Body of the second version", status: "published")
+      @draft_version_3 = create(:legislation_draft_version, process: @process, title: "Version 3", body: "Body of the third version", status: "draft")
     end
 
     it "shows the text body for this version" do
       visit legislation_process_draft_version_path(@process, @draft_version_1)
 
       expect(page).to have_content("Body of the first version")
+
+      within('select#draft_version_id') do
+        expect(page).to have_content("Version 1")
+        expect(page).to have_content("Version 2")
+        expect(page).to_not have_content("Version 3")
+      end
+    end
+
+    it "shows an unpublished version to admins" do
+      login_as(administrator)
+
+      visit legislation_process_draft_version_path(@process, @draft_version_3)
+
+      expect(page).to have_content("Body of the third version")
+
+      within('select#draft_version_id') do
+        expect(page).to have_content("Version 1")
+        expect(page).to have_content("Version 2")
+        expect(page).to_not have_content("Version 3")
+      end
     end
 
     it "switches to another version without js" do
@@ -40,14 +66,35 @@ feature 'Legislation Draft Versions' do
   context "See changes page" do
     before(:each) do
       @process = create(:legislation_process)
-      @draft_version_1 = create(:legislation_draft_version, process: @process, title: "Version 1", body: "Body of the first version", changelog: "Changes for first version")
-      @draft_version_2 = create(:legislation_draft_version, process: @process, title: "Version 2", body: "Body of the second version", changelog: "Changes for second version")
+      @draft_version_1 = create(:legislation_draft_version, process: @process, title: "Version 1", body: "Body of the first version", changelog: "Changes for first version", status: "published")
+      @draft_version_2 = create(:legislation_draft_version, process: @process, title: "Version 2", body: "Body of the second version", changelog: "Changes for second version", status: "published")
+      @draft_version_3 = create(:legislation_draft_version, process: @process, title: "Version 3", body: "Body of the third version", changelog: "Changes for third version", status: "draft")
     end
 
-    it "shows the text body for this version" do
+    it "shows the changes for this version" do
       visit legislation_process_draft_version_changes_path(@process, @draft_version_1)
 
       expect(page).to have_content("Changes for first version")
+
+      within('select#draft_version_id') do
+        expect(page).to have_content("Version 1")
+        expect(page).to have_content("Version 2")
+        expect(page).to_not have_content("Version 3")
+      end
+    end
+
+    it "shows an unpublished version to admins" do
+      login_as(administrator)
+
+      visit legislation_process_draft_version_changes_path(@process, @draft_version_3)
+
+      expect(page).to have_content("Changes for third version")
+
+      within('select#draft_version_id') do
+        expect(page).to have_content("Version 1")
+        expect(page).to have_content("Version 2")
+        expect(page).to_not have_content("Version 3")
+      end
     end
 
     it "switches to another version without js" do