Enables RSpec/ExampleWording and fixes all issues
Both avoiding 'should' and repiting 'it' on the tests description improves reading them and also makes all descriptions consistent. Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
This commit is contained in:
@@ -3,27 +3,27 @@ require 'rails_helper'
|
||||
describe PagesController do
|
||||
|
||||
describe 'Static pages' do
|
||||
it 'should include a privacy page' do
|
||||
it 'includes a privacy page' do
|
||||
get :show, id: :privacy
|
||||
expect(response).to be_ok
|
||||
end
|
||||
|
||||
it 'should include a conditions page' do
|
||||
it 'includes a conditions page' do
|
||||
get :show, id: :conditions
|
||||
expect(response).to be_ok
|
||||
end
|
||||
|
||||
it 'should include a general terms page' do
|
||||
it 'includes a general terms page' do
|
||||
get :show, id: :general_terms
|
||||
expect(response).to be_ok
|
||||
end
|
||||
|
||||
it 'should include a terms page' do
|
||||
it 'includes a terms page' do
|
||||
get :show, id: :census_terms
|
||||
expect(response).to be_ok
|
||||
end
|
||||
|
||||
it 'should include a accessibility page' do
|
||||
it 'includes a accessibility page' do
|
||||
get :show, id: :accessibility
|
||||
expect(response).to be_ok
|
||||
end
|
||||
@@ -31,24 +31,24 @@ describe PagesController do
|
||||
|
||||
describe 'More info pages' do
|
||||
|
||||
it 'should include a more info page' do
|
||||
it 'includes a more info page' do
|
||||
get :show, id: 'more_info/index'
|
||||
expect(response).to be_ok
|
||||
end
|
||||
|
||||
it 'should include a how_to_use page' do
|
||||
it 'includes a how_to_use page' do
|
||||
get :show, id: 'more_info/how_to_use/index'
|
||||
expect(response).to be_ok
|
||||
end
|
||||
|
||||
it 'should include a faq page' do
|
||||
it 'includes a faq page' do
|
||||
get :show, id: 'more_info/faq/index'
|
||||
expect(response).to be_ok
|
||||
end
|
||||
end
|
||||
|
||||
describe 'Not found pages' do
|
||||
it 'should return a 404 message' do
|
||||
it 'returns a 404 message' do
|
||||
get :show, id: "nonExistentPage"
|
||||
expect(response).to be_missing
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user