Use finished trait to simplify code

It's more concise than writing `valuation_finished: true`.
2019-09-21 14:31:58 +02:00
parent 30a30c5f00
commit eb53e033be
4 changed files with 28 additions and 36 deletions
--- a/spec/features/valuation/budget_investments_spec.rb
+++ b/spec/features/valuation/budget_investments_spec.rb
@@ -210,9 +210,9 @@ describe "Valuation budget investments" do
    scenario "Index filtering by valuation status" do
      valuating = create(:budget_investment, :visible_to_valuators, budget: budget,
                                                                    title: "Ongoing valuation")
-      valuated  = create(:budget_investment, :visible_to_valuators, budget: budget,
-                                                                    title: "Old idea",
-                                                                    valuation_finished: true)
+      valuated  = create(:budget_investment, :visible_to_valuators, :finished,
+                                                                    budget: budget,
+                                                                    title: "Old idea")
      valuating.valuators << valuator
      valuated.valuators << valuator