From ea38f794423277c0a8e3153f51ed3c5240a1d84a Mon Sep 17 00:00:00 2001
From: decabeza <alberto@decabeza.es>
Date: Mon, 5 Jun 2017 17:55:37 +0200
Subject: [PATCH] removes specs of proposals successful banner

---
 app/controllers/proposals_controller.rb |  6 ++++++
 spec/features/proposal_ballots_spec.rb  | 15 ---------------
 spec/features/proposals_spec.rb         | 15 ---------------
 3 files changed, 6 insertions(+), 30 deletions(-)

diff --git a/app/controllers/proposals_controller.rb b/app/controllers/proposals_controller.rb
index b4599676d..17b1ff375 100644
--- a/app/controllers/proposals_controller.rb
+++ b/app/controllers/proposals_controller.rb
@@ -35,6 +35,8 @@ class ProposalsController < ApplicationController
   def index_customization
     discard_archived
     load_retired
+    load_successful_proposals
+    load_featured unless @proposal_successful_exists
   end
 
   def vote
@@ -113,4 +115,8 @@ class ProposalsController < ApplicationController
         @resources = @resources.where('proposals.id NOT IN (?)', @featured_proposals.map(&:id))
       end
     end
+
+    def load_successful_proposals
+      @proposal_successful_exists = Proposal.successful.exists?
+    end
 end
diff --git a/spec/features/proposal_ballots_spec.rb b/spec/features/proposal_ballots_spec.rb
index 8f5e99eb8..1ec99d3d0 100644
--- a/spec/features/proposal_ballots_spec.rb
+++ b/spec/features/proposal_ballots_spec.rb
@@ -3,21 +3,6 @@ require 'rails_helper'
 
 feature 'Proposal ballots' do
 
-  scenario 'Banner shows in proposal index' do
-    create_featured_proposals
-
-    visit proposals_path
-    expect(page).to_not have_css("#next-voting")
-    expect(page).to have_css("#featured-proposals")
-
-    create_successful_proposals
-
-    visit proposals_path
-
-    expect(page).to have_css("#next-voting")
-    expect(page).to_not have_css("#featured-proposals")
-  end
-
   scenario 'Successful proposals do not show support buttons in index' do
     successful_proposals = create_successful_proposals
 
diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb
index bc0ed7f49..69f77bdad 100644
--- a/spec/features/proposals_spec.rb
+++ b/spec/features/proposals_spec.rb
@@ -1431,21 +1431,6 @@ end
 
 feature 'Successful proposals' do
 
-  scenario 'Banner shows in proposal index' do
-    create_featured_proposals
-
-    visit proposals_path
-    expect(page).to_not have_css("#next-voting")
-    expect(page).to have_css("#featured-proposals")
-
-    create_successful_proposals
-
-    visit proposals_path
-
-    expect(page).to have_css("#next-voting")
-    expect(page).to_not have_css("#featured-proposals")
-  end
-
   scenario 'Successful proposals do not show support buttons in index' do
     successful_proposals = create_successful_proposals