From 21634cf4fe4a1cf7f5a2960c74ca05a4347129dd Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 16 Sep 2019 16:47:42 +0000 Subject: [PATCH 1/2] Bump rubocop-rspec from 1.33.0 to 1.35.0 Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.33.0 to 1.35.0. - [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.33.0...v1.35.0) Signed-off-by: dependabot-preview[bot] --- Gemfile | 2 +- Gemfile.lock | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile b/Gemfile index 78c34c2b5..5f2ba0567 100644 --- a/Gemfile +++ b/Gemfile @@ -97,7 +97,7 @@ group :development do gem "erb_lint", require: false gem "mdl", "~> 0.5.0", require: false gem "rubocop", "~> 0.60.0", require: false - gem "rubocop-rspec", "~> 1.33.0", require: false + gem "rubocop-rspec", "~> 1.35.0", require: false gem "rvm1-capistrano3", "~> 1.4.0", require: false gem "scss_lint", "~> 0.55.0", require: false gem "web-console", "~> 3.3.0" diff --git a/Gemfile.lock b/Gemfile.lock index e0d5a47dd..a0df9350c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -276,7 +276,7 @@ GEM railties (>= 3.1, < 6.0) invisible_captcha (0.10.0) rails (>= 3.2.0) - jaro_winkler (1.5.2) + jaro_winkler (1.5.3) jquery-fileupload-rails (0.4.7) actionpack (>= 3.1) railties (>= 3.1) @@ -467,7 +467,7 @@ GEM rainbow (>= 2.2.2, < 4.0) ruby-progressbar (~> 1.7) unicode-display_width (~> 1.4.0) - rubocop-rspec (1.33.0) + rubocop-rspec (1.35.0) rubocop (>= 0.60.0) ruby-progressbar (1.10.1) rubyzip (1.2.2) @@ -648,7 +648,7 @@ DEPENDENCIES rollbar (~> 2.18.0) rspec-rails (~> 3.8) rubocop (~> 0.60.0) - rubocop-rspec (~> 1.33.0) + rubocop-rspec (~> 1.35.0) rvm1-capistrano3 (~> 1.4.0) sass-rails (~> 5.0, >= 5.0.4) savon (~> 2.12.0) From 766f82a5763b3351401737af55d0a4ee29212d23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 19 Sep 2019 16:31:23 +0200 Subject: [PATCH 2/2] Apply RSpec/ExampleWording rubocop rule This rule was improved in rubocop-rspec 1.35.0 and now it detects a case it didn't detect in the past. --- spec/models/budget/investment_spec.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spec/models/budget/investment_spec.rb b/spec/models/budget/investment_spec.rb index 380082912..9230b4810 100644 --- a/spec/models/budget/investment_spec.rb +++ b/spec/models/budget/investment_spec.rb @@ -554,8 +554,7 @@ describe Budget::Investment do expect(described_class.sort_by_title.map(&:title)).to eq %w[CCCC DDDD] end - it "should take into consideration title fallbacks when there is no - translation for current locale" do + it "takes into consideration title fallbacks when there is no translation for current locale" do create(:budget_investment, title: "BBBB") Globalize.with_locale(:es) do I18n.with_locale(:es) do