consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply rubocop rules for empty lines

Browse Source 
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
spec/shared/features/remotely_translatable.rb
View File

@@ -1,5 +1,4 @@
shared_examples "remotely_translatable" do |factory_name, path_name, path_arguments|
let(:arguments) do
path_arguments.map do |argument_name, path_to_value|
[argument_name, resource.send(path_to_value)]
@@ -16,7 +15,6 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
end
context "Button to request remote translation" do
scenario "should not be present when current locale translation exists", :js do
visit path
@@ -64,7 +62,6 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
end
describe "should ignore missing translations on resource comments" do
before do
if show_path?(path_name) || !commentable?(resource)
skip("only index_path")
@@ -81,11 +78,9 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
expect(page).not_to have_button("Translate page")
end
end
describe "should evaluate missing translations on resource comments" do
before do
if index_path?(path_name)
skip("only show_path")
@@ -113,11 +108,9 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
expect(page).not_to have_button("Translate page")
end
end
describe "should evaluate missing translations on featured_debates" do
before { skip("only debates index path") if path_name != "debates_path" }
scenario "display when exists featured_debates without tanslations", :js do
@@ -130,11 +123,9 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
expect(page).to have_button("Translate page")
end
end
describe "should evaluate missing translations on featured_proposals" do
before { skip("only proposals index path") if path_name != "proposals_path" }
scenario "display when exists featured_proposals without tanslations", :js do
@@ -147,13 +138,10 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
expect(page).to have_button("Translate page")
end
end
end
context "After click remote translations button" do
describe "with delayed jobs", :delay_jobs do
scenario "the remote translation button should not be present", :js do
visit path
@@ -194,11 +182,9 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
expect(page).not_to have_content("Translations have been correctly requested.")
expect(page).to have_content("In a short period of time refreshing the page you will be able to see all the content in your language.")
end
end
describe "without delayed jobs" do
scenario "the remote translation button should not be present", :js do
microsoft_translate_client_response = generate_response(resource)
expect_any_instance_of(RemoteTranslations::Microsoft::Client).to receive(:call).and_return(microsoft_translate_client_response)
@@ -221,11 +207,8 @@ shared_examples "remotely_translatable" do |factory_name, path_name, path_argume
expect(RemoteTranslation.count).to eq(0)
expect(resource.translations.count).to eq(2)
end
end
end
end
def add_translations(resource)