Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -1,12 +1,10 @@
require "rails_helper"
describe Verification::Residence do
let!(:geozone) { create(:geozone, census_code: "01") }
let(:residence) { build(:verification_residence, document_number: "12345678Z") }
describe "validations" do
it "is valid" do
expect(residence).to be_valid
end
@@ -48,7 +46,6 @@ describe Verification::Residence do
residence.terms_of_service = nil
expect(residence).not_to be_valid
end
end
describe "new" do
@@ -64,7 +61,6 @@ describe Verification::Residence do
end
describe "save" do
it "stores document number, document type, geozone, date of birth and gender" do
user = create(:user)
residence.user = user
@@ -79,7 +75,6 @@ describe Verification::Residence do
expect(user.gender).to eq("male")
expect(user.geozone).to eq(geozone)
end
end
describe "tries" do
@@ -111,5 +106,4 @@ describe Verification::Residence do
)
end
end
end