Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -1,11 +1,9 @@
require "rails_helper"
describe Verification::Management::Document do
let(:verification_document) { build(:verification_document, document_number: "12345678Z") }
describe "validations" do
it "is valid" do
expect(verification_document).to be_valid
end
@@ -31,7 +29,6 @@ describe Verification::Management::Document do
end
describe "custom validations with RemoteCensus enabled" do
before do
Setting["feature.remote_census"] = true
Setting["remote_census.request.date_of_birth"] = "some.value"
@@ -86,7 +83,6 @@ describe Verification::Management::Document do
expect(verification_document.errors[:date_of_birth]).to include("can't be blank")
end
end
end
describe "Allowed Age" do
@@ -130,5 +126,4 @@ describe Verification::Management::Document do
end
end
end
end