Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -62,7 +62,6 @@ describe RemoteCensusApi do
|
||||
end
|
||||
|
||||
describe "request structure correctly filled" do
|
||||
|
||||
before do
|
||||
Setting["feature.remote_census"] = true
|
||||
Setting["remote_census.request.structure"] = '{ "request":
|
||||
@@ -149,11 +148,9 @@ describe RemoteCensusApi do
|
||||
"nivel" => 3 }
|
||||
})
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "get_response_body" do
|
||||
|
||||
before do
|
||||
Setting["feature.remote_census"] = true
|
||||
end
|
||||
@@ -185,11 +182,9 @@ describe RemoteCensusApi do
|
||||
}
|
||||
})
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
describe "RemoteCensusApi::Response" do
|
||||
|
||||
before do
|
||||
Setting["feature.remote_census"] = true
|
||||
access_user_data = "get_habita_datos_response.get_habita_datos_return.datos_habitante.item"
|
||||
@@ -217,7 +212,5 @@ describe RemoteCensusApi do
|
||||
expect(response.gender).to eq "male"
|
||||
expect(response.name).to eq "José García"
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user