Replace == 0 comparisions for .zero?

This commit is contained in:
Bertocq
2017-11-13 02:27:38 +01:00
parent bfd1a75af7
commit db54273dad
2 changed files with 10 additions and 10 deletions

View File

@@ -41,7 +41,7 @@ class Poll::Question::Answer < ActiveRecord::Base
end end
def total_votes_percentage def total_votes_percentage
question.answers_total_votes == 0 ? 0 : (total_votes * 100) / question.answers_total_votes question.answers_total_votes.zero? ? 0 : (total_votes * 100) / question.answers_total_votes
end end
def set_most_voted def set_most_voted

View File

@@ -27,7 +27,7 @@ class Poll
def total_participants_web_percentage def total_participants_web_percentage
stats_cache('total_participants_web_percentage') do stats_cache('total_participants_web_percentage') do
total_participants == 0 ? 0 : total_participants_web * 100 / total_participants total_participants.zero? ? 0 : total_participants_web * 100 / total_participants
end end
end end
@@ -37,7 +37,7 @@ class Poll
def total_participants_booth_percentage def total_participants_booth_percentage
stats_cache('total_participants_booth_percentage') do stats_cache('total_participants_booth_percentage') do
total_participants == 0 ? 0 : total_participants_booth * 100 / total_participants.to_f total_participants.zero? ? 0 : total_participants_booth * 100 / total_participants.to_f
end end
end end
@@ -47,7 +47,7 @@ class Poll
def valid_percentage_web def valid_percentage_web
stats_cache('valid_percentage_web') do stats_cache('valid_percentage_web') do
total_valid_votes == 0 ? 0 : total_web_valid * 100 / total_valid_votes.to_f total_valid_votes.zero? ? 0 : total_web_valid * 100 / total_valid_votes.to_f
end end
end end
@@ -73,7 +73,7 @@ class Poll
def valid_percentage_booth def valid_percentage_booth
stats_cache('valid_percentage_booth') do stats_cache('valid_percentage_booth') do
total_valid_votes == 0 ? 0 : total_booth_valid * 100 / total_valid_votes.to_f total_valid_votes.zero? ? 0 : total_booth_valid * 100 / total_valid_votes.to_f
end end
end end
@@ -83,7 +83,7 @@ class Poll
def white_percentage_booth def white_percentage_booth
stats_cache('white_percentage_booth') do stats_cache('white_percentage_booth') do
total_white_votes == 0 ? 0 : total_booth_white * 100 / total_white_votes.to_f total_white_votes.zero? ? 0 : total_booth_white * 100 / total_white_votes.to_f
end end
end end
@@ -93,7 +93,7 @@ class Poll
def null_percentage_booth def null_percentage_booth
stats_cache('null_percentage_booth') do stats_cache('null_percentage_booth') do
total_null_votes == 0 ? 0 : total_booth_null * 100 / total_null_votes.to_f total_null_votes.zero? ? 0 : total_booth_null * 100 / total_null_votes.to_f
end end
end end
@@ -103,7 +103,7 @@ class Poll
def total_valid_percentage def total_valid_percentage
stats_cache('total_valid_percentage') do stats_cache('total_valid_percentage') do
total_participants == 0 ? 0 : total_valid_votes * 100 / total_participants.to_f total_participants.zero? ? 0 : total_valid_votes * 100 / total_participants.to_f
end end
end end
@@ -113,7 +113,7 @@ class Poll
def total_white_percentage def total_white_percentage
stats_cache('total_white_percentage') do stats_cache('total_white_percentage') do
total_participants == 0 ? 0 : total_white_votes * 100 / total_participants.to_f total_participants.zero? ? 0 : total_white_votes * 100 / total_participants.to_f
end end
end end
@@ -123,7 +123,7 @@ class Poll
def total_null_percentage def total_null_percentage
stats_cache('total_null_percentage') do stats_cache('total_null_percentage') do
total_participants == 0 ? 0 : total_null_votes * 100 / total_participants.to_f total_participants.zero? ? 0 : total_null_votes * 100 / total_participants.to_f
end end
end end