From d99ca9bd34643a45126fe55d1b0984a7576f3073 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Thu, 26 Nov 2020 13:12:26 +0100
Subject: [PATCH] Use CSS to make items bold in the admin menu

From a semantic point of view, there's no reason to add a strong
emphasis to the menu items.

Besides, using CSS simplifies the code and is less error-prone. For
instance, the "stats" section didn't have a <strong> tag, and so it was
the only one which wasn't bold.
---
 app/assets/stylesheets/admin/menu.scss       |  4 +++
 app/components/admin/menu_component.html.erb | 28 ++++++++++----------
 app/views/management/_menu.html.erb          |  2 +-
 3 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/app/assets/stylesheets/admin/menu.scss b/app/assets/stylesheets/admin/menu.scss
index 482d2db91..fdbe295b0 100644
--- a/app/assets/stylesheets/admin/menu.scss
+++ b/app/assets/stylesheets/admin/menu.scss
@@ -20,6 +20,10 @@
     }
   }
 
+  > ul > li a {
+    font-weight: bold;
+  }
+
   li {
     margin: 0;
     outline: 0;
diff --git a/app/components/admin/menu_component.html.erb b/app/components/admin/menu_component.html.erb
index 657d0eebf..36d96702e 100644
--- a/app/components/admin/menu_component.html.erb
+++ b/app/components/admin/menu_component.html.erb
@@ -3,7 +3,7 @@
     <li>
       <%= link_to admin_proposals_path do %>
         <span class="icon-proposals"></span>
-        <strong><%= t("admin.menu.proposals") %></strong>
+        <%= t("admin.menu.proposals") %>
       <% end %>
     </li>
   <% end %>
@@ -12,7 +12,7 @@
     <li class="<%= "is-active" if controller_name == "debates" %>">
       <%= link_to admin_debates_path do %>
         <span class="icon-debates"></span>
-        <strong><%= t("admin.menu.debates") %></strong>
+        <%= t("admin.menu.debates") %>
       <% end %>
     </li>
   <% end %>
@@ -20,7 +20,7 @@
   <li class="<%= "is-active" if controller_name == "comments" %>">
     <%= link_to admin_comments_path do %>
       <span class="icon-comments"></span>
-      <strong><%= t("admin.menu.comments") %></strong>
+      <%= t("admin.menu.comments") %>
     <% end %>
   </li>
 
@@ -28,7 +28,7 @@
     <li class="<%= "is-active" if polls? %>">
       <%= link_to admin_polls_path do %>
         <span class="icon-checkmark-circle"></span>
-        <strong><%= t("admin.menu.polls") %></strong>
+        <%= t("admin.menu.polls") %>
       <% end %>
     </li>
   <% end %>
@@ -37,7 +37,7 @@
     <li class="<%= "is-active" if controller.class.parent == Admin::Legislation %>">
       <%= link_to admin_legislation_processes_path do %>
         <span class="icon-file-text"></span>
-        <strong><%= t("admin.menu.legislation") %></strong>
+        <%= t("admin.menu.legislation") %>
       <% end %>
     </li>
   <% end %>
@@ -46,7 +46,7 @@
     <li class="<%= "is-active" if budgets? %>">
       <%= link_to admin_budgets_path do %>
         <span class="icon-budget"></span>
-        <strong><%= t("admin.menu.budgets") %></strong>
+        <%= t("admin.menu.budgets") %>
       <% end %>
     </li>
   <% end %>
@@ -54,7 +54,7 @@
   <li>
     <a href="#">
       <span class="icon-box"></span>
-      <strong><%= t("admin.menu.title_booths") %></strong>
+      <%= t("admin.menu.title_booths") %>
     </a>
     <ul id="booths_menu" <%= "class=is-active" if booths? %>>
       <li <%= "class=is-active" if %w[officers officer_assignments].include?(controller_name) %>>
@@ -84,7 +84,7 @@
     <li class="<%= "is-active" if controller_name == "signature_sheets" %>">
       <%= link_to admin_signature_sheets_path do %>
         <span class="icon-file-text-o"></span>
-        <strong><%= t("admin.menu.signature_sheets") %></strong>
+        <%= t("admin.menu.signature_sheets") %>
       <% end %>
     </li>
   <% end %>
@@ -92,7 +92,7 @@
   <li>
     <a href="#">
       <span class="icon-zip"></span>
-      <strong><%= t("admin.menu.messaging_users") %></strong>
+      <%= t("admin.menu.messaging_users") %>
     </a>
     <ul id="messaging_users_menu" <%= "class=is-active" if messages_menu_active? %>>
       <li <%= "class=is-active" if controller_name == "newsletters" %>>
@@ -113,7 +113,7 @@
   <li>
     <a href="#">
       <span class="icon-edit"></span>
-      <strong><%= t("admin.menu.title_site_customization") %></strong>
+      <%= t("admin.menu.title_site_customization") %>
     </a>
     <ul <%= "class=is-active" if customization? &&
                                  controller.class.parent != Admin::Poll::Questions::Answers %>>
@@ -144,7 +144,7 @@
   <li>
     <a href="#">
       <span class="icon-eye"></span>
-      <strong><%= t("admin.menu.title_moderated_content") %></strong>
+      <%= t("admin.menu.title_moderated_content") %>
     </a>
     <ul <%= "class=is-active" if moderated_content? %>>
       <% if feature?(:proposals) %>
@@ -186,7 +186,7 @@
   <li>
     <a href="#">
       <span class="icon-organizations"></span>
-      <strong><%= t("admin.menu.title_profiles") %></strong>
+      <%= t("admin.menu.title_profiles") %>
     </a>
     <ul <%= "class=is-active" if profiles? %>>
       <li <%= "class=is-active" if controller_name == "administrators" %>>
@@ -228,7 +228,7 @@
   <li>
     <a href="#">
       <span class="icon-settings"></span>
-      <strong><%= t("admin.menu.title_settings") %></strong>
+      <%= t("admin.menu.title_settings") %>
     </a>
     <ul <%= "class=is-active" if settings? %>>
       <li <%= "class=is-active" if controller_name == "settings" %>>
@@ -260,7 +260,7 @@
   <li>
     <a href="#">
       <span class="icon-check"></span>
-      <strong><%= t("admin.menu.dashboard") %></strong>
+      <%= t("admin.menu.dashboard") %>
     </a>
     <ul <%= "class=is-active" if dashboard? %>>
       <li <%= "class=is-active" if controller_name == "actions" %>>
diff --git a/app/views/management/_menu.html.erb b/app/views/management/_menu.html.erb
index 2eb65d5b7..1827bcf15 100644
--- a/app/views/management/_menu.html.erb
+++ b/app/views/management/_menu.html.erb
@@ -2,7 +2,7 @@
   <li class="section-title">
     <a href="#">
       <span class="icon-user"></span>
-      <strong><%= t("management.menu.users") %></strong>
+      <%= t("management.menu.users") %>
     </a>
     <ul class="is-active">