From d7f26f012d1db0f2b6938a2aadce99980c634f30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 17 Oct 2021 15:57:12 +0200 Subject: [PATCH] Fix test checking link in budget header The test was passing because we were using `within`, but actually the `have_css` method doesn't support the `href:` argument. --- spec/components/budgets/budget_component_spec.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/components/budgets/budget_component_spec.rb b/spec/components/budgets/budget_component_spec.rb index 98c0ef338..95fd023c7 100644 --- a/spec/components/budgets/budget_component_spec.rb +++ b/spec/components/budgets/budget_component_spec.rb @@ -23,16 +23,16 @@ describe Budgets::BudgetComponent do it "shows budget main link when defined" do render_inline Budgets::BudgetComponent.new(budget) - within(".budget-header") do - expect(page).not_to have_css("a.main-link") + page.find(".budget-header") do |header| + expect(header).not_to have_css ".main-link" end - budget.update!(main_link_text: "Partitipate now!", main_link_url: "https://consulproject.org") + budget.update!(main_link_text: "Participate now!", main_link_url: "https://consulproject.org") render_inline Budgets::BudgetComponent.new(budget) - within(".budget-header") do - expect(page).to have_css("a.main-link", text: "Participate now!", href: "https://consulproject.org") + page.find(".budget-header") do |header| + expect(header).to have_link "Participate now!", href: "https://consulproject.org", class: "main-link" end end end