From d46a2f9335e203633d0374e224e9fb019e7f917c Mon Sep 17 00:00:00 2001
From: Alberto Garcia Cabeza <alberto@decabeza.es>
Date: Wed, 4 May 2016 15:21:20 +0200
Subject: [PATCH] Includes aria hidden attribute on support buttons

---
 app/helpers/accessibility_helper.rb          | 7 +++++++
 app/views/debates/_votes.html.erb            | 6 +++---
 app/views/proposals/_votes.html.erb          | 6 +++---
 app/views/spending_proposals/_votes.html.erb | 5 +++--
 4 files changed, 16 insertions(+), 8 deletions(-)
 create mode 100644 app/helpers/accessibility_helper.rb

diff --git a/app/helpers/accessibility_helper.rb b/app/helpers/accessibility_helper.rb
new file mode 100644
index 000000000..a224f9a9b
--- /dev/null
+++ b/app/helpers/accessibility_helper.rb
@@ -0,0 +1,7 @@
+module AccessibilityHelper
+
+  def css_for_aria_hidden(reason)
+    reason.present? ? "true" : ""
+  end
+
+end
diff --git a/app/views/debates/_votes.html.erb b/app/views/debates/_votes.html.erb
index a4fd722ee..9ac6638d6 100644
--- a/app/views/debates/_votes.html.erb
+++ b/app/views/debates/_votes.html.erb
@@ -22,20 +22,20 @@
   </span>
 
   <% if user_signed_in? && current_user.organization? %>
-  <div class="organizations-votes" style='display:none'>
+  <div class="organizations-votes" style='display:none' aria-hidden="false">
     <p>
       <%= t("votes.organizations") %>
     </p>
   </div>
   <% elsif user_signed_in? && !debate.votable_by?(current_user)%>
-  <div class="anonymous-votes" style='display:none'>
+  <div class="anonymous-votes" style='display:none' aria-hidden="false">
     <p>
       <%= t("votes.anonymous",
           verify_account: link_to(t("votes.verify_account"), verification_path )).html_safe %>
     </p>
   </div>
   <% elsif !user_signed_in? %>
-  <div class="not-logged" style='display:none'>
+  <div class="not-logged" style='display:none' aria-hidden="false">
     <%= t("votes.unauthenticated",
       signin: link_to(t("votes.signin"), new_user_session_path),
       signup: link_to(t("votes.signup"), new_user_registration_path)).html_safe %>
diff --git a/app/views/proposals/_votes.html.erb b/app/views/proposals/_votes.html.erb
index 65d970530..0c572e71f 100644
--- a/app/views/proposals/_votes.html.erb
+++ b/app/views/proposals/_votes.html.erb
@@ -31,20 +31,20 @@
   </div>
 
   <% if user_signed_in? && current_user.organization? %>
-  <div class="organizations-votes" style='display:none'>
+  <div class="organizations-votes" style='display:none' aria-hidden="false">
     <p>
       <%= t("votes.organizations") %>
     </p>
   </div>
   <% elsif user_signed_in? && !proposal.votable_by?(current_user)%>
-  <div class="anonymous-votes" style='display:none'>
+  <div class="anonymous-votes" style='display:none' aria-hidden="false">
     <p>
       <%= t("votes.verified_only",
           verify_account: link_to(t("votes.verify_account"), verification_path )).html_safe %>
     </p>
   </div>
   <% elsif !user_signed_in? %>
-  <div class="not-logged" style='display:none'>
+  <div class="not-logged" style='display:none' aria-hidden="false">
     <%= t("votes.unauthenticated",
       signin: link_to(t("votes.signin"), new_user_session_path),
       signup: link_to(t("votes.signup"), new_user_registration_path)).html_safe %>
diff --git a/app/views/spending_proposals/_votes.html.erb b/app/views/spending_proposals/_votes.html.erb
index 85220d6c9..a4fd43993 100644
--- a/app/views/spending_proposals/_votes.html.erb
+++ b/app/views/spending_proposals/_votes.html.erb
@@ -16,14 +16,15 @@
     <% elsif voting_allowed %>
       <%= link_to vote_url,
           class: "button button-support small expanded",
-          title: t('spending_proposals.spending_proposal.support_title'), method: "post", remote: true do %>
+          title: t('spending_proposals.spending_proposal.support_title'), method: "post", remote: true,
+          "aria-hidden" => css_for_aria_hidden(reason) do %>
         <%= t("spending_proposals.spending_proposal.support") %>
       <% end %>
     <% end %>
   </div>
 
   <% if reason.present? && !user_voted_for %>
-    <div class="no-supports-allowed" style='display:none'>
+    <div class="no-supports-allowed" style='display:none' aria-hidden="false">
       <p>
           <%= t("votes.spending_proposals.#{reason}",
                 verify_account: link_to(t("votes.verify_account"), verification_path),