From d254fcd7ca4571a3ee82d63685c0f3dd44607ba0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 12 Oct 2024 17:49:56 +0200 Subject: [PATCH] Fix missing "for" attribute in user segments label Since the attribute was missing, the label wasn't correctly associated with its field. --- app/views/admin/emails_download/index.html.erb | 2 +- spec/system/admin/emails/emails_download_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/admin/emails_download/index.html.erb b/app/views/admin/emails_download/index.html.erb index 3fd0f2f01..49b086ef5 100644 --- a/app/views/admin/emails_download/index.html.erb +++ b/app/views/admin/emails_download/index.html.erb @@ -5,7 +5,7 @@ method: :get, id: "admin_download_emails" do %> - + <%= label_tag :users_segment, t("admin.emails_download.index.download_segment") %>

<%= t("admin.emails_download.index.download_segment_help_text") %>

diff --git a/spec/system/admin/emails/emails_download_spec.rb b/spec/system/admin/emails/emails_download_spec.rb index 7de835565..9e784cc05 100644 --- a/spec/system/admin/emails/emails_download_spec.rb +++ b/spec/system/admin/emails/emails_download_spec.rb @@ -26,7 +26,7 @@ describe "Admin download user emails" do visit admin_emails_download_index_path within("#admin_download_emails") do - select "Administrators", from: "users_segment" + select "Administrators", from: "Download email addresses" click_button "Download emails list" end