Refactor method to display valuator abilities

Using `select` is easier to follow than adding `nil` to an array and
then using `compact`.
This commit is contained in:
Javi Martín
2019-11-05 16:54:30 +01:00
parent cbe6af3eb7
commit d077f7c14b

View File

@@ -4,8 +4,9 @@ module ValuatorsHelper
end end
def valuator_abilities(valuator) def valuator_abilities(valuator)
[valuator.can_comment ? I18n.t("admin.valuators.index.can_comment") : nil, %w[can_comment can_edit_dossier]
valuator.can_edit_dossier ? I18n.t("admin.valuators.index.can_edit_dossier") : nil .select { |permission| valuator.send("#{permission}?") }
].compact.join(", ") .map { |permission| I18n.t("admin.valuators.index.#{permission}") }
.join(", ")
end end
end end