From ceee25fdc9546ff5bbc62339efc575f52ec87c8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 28 Jul 2020 20:25:48 +0200 Subject: [PATCH] Don't re-render the ballot twice We were rendering an individual ballot, and then rendering all ballots (including the already rendered one). So we can skip the first part, as pointed out by microweb10 in the comments of pull request 3036. --- app/views/budgets/ballot/lines/create.js.erb | 4 ---- app/views/budgets/ballot/lines/destroy.js.erb | 4 ---- 2 files changed, 8 deletions(-) diff --git a/app/views/budgets/ballot/lines/create.js.erb b/app/views/budgets/ballot/lines/create.js.erb index 22617ef02..e6569e69a 100644 --- a/app/views/budgets/ballot/lines/create.js.erb +++ b/app/views/budgets/ballot/lines/create.js.erb @@ -1,9 +1,5 @@ $("#progress_bar").html("<%= j render("/budgets/ballot/progress_bar", ballot: @ballot) %>"); $("#sidebar").html("<%= j render("/budgets/investments/sidebar") %>"); -$("#<%= dom_id(@investment) %>_ballot").html("<%= j render("/budgets/investments/ballot", - investment: @investment, - investment_ids: @investment_ids, - ballot: @ballot) %>"); <%= render "refresh_ballots", investment_ids: @investment_ids, diff --git a/app/views/budgets/ballot/lines/destroy.js.erb b/app/views/budgets/ballot/lines/destroy.js.erb index 078fae9a9..106cac60d 100644 --- a/app/views/budgets/ballot/lines/destroy.js.erb +++ b/app/views/budgets/ballot/lines/destroy.js.erb @@ -2,10 +2,6 @@ $("#progress_bar").html("<%= j render("budgets/ballot/progress_bar", ballot: @ba $("#sidebar").html("<%= j render("budgets/investments/sidebar") %>"); $("#ballot").html("<%= j render("budgets/ballot/ballot") %>") -$("#<%= dom_id(@investment) %>_ballot").html("<%= j render("/budgets/investments/ballot", - investment: @investment, - investment_ids: @investment_ids, - ballot: @ballot) %>"); <%= render "refresh_ballots", investment_ids: @investment_ids, ballot: @ballot %>